Incorrect colours and styles from git bash on Windows

[olivif]

I will investigate how this can be made better for Windows and follow up on here 😃

[IonicaBizau]

@olivif Thanks! Should you have any questions, let me know! 😁

[olivif]

So, after some quick investigations, here's what I found 😄

This line is the culprit to some of the windows issues

, fg: ["\u001b[38;5;", "\u001b[39m"]

It seems like on windows cmd that string is interpreted differently.

I made a quick prototype and it seems to work.

It seems like node-couleurs supports any hex/rgb code, so we would probably need a way of mapping that to this list ..

Also, it seems like this is a pretty solved problem on both colors.js and chalk.

[IonicaBizau]

@olivif 😁

Does Windows cmd support 256 colors like UNIX/Linux terminals do?
If that is so, I wonder if x256 works smoothly on Windows.

From what I saw, colors.js and chalk don't support hex color input.

[IonicaBizau]

@olivif Any news on this?

[olivif]

I had a look, x256 doesn't work very well on windows either 😦

[IonicaBizau]

I'm on it. 🚀

[IonicaBizau]

🚢 6.0.0 🎉 /cc #17

Using ansy, we try to get the best support for the rgb/hex colors, in this order: 16m colors, 256 colors, 16 colors, no colors. 😂

[olivif]

@IonicaBizau great stuff! much better

[IonicaBizau]

@olivif For posterity: the Windows command prompt does not support 256 colors. It supports only 16 colors. I'm wondering how the new version of image-to-ascii (currently in the lwip branch) works in Windows cmd. 😄

[olivif]

npm install imgpx fails miserably on my windows machine, I think I have a newer version of the cpp compiler and it really doesn't like it. So I wasn't able to try it 😄

[IonicaBizau]

@olivif Do you have Visual Studio 2013 on your machine? I guess lwip fails to be compiled.

[olivif]

Yes, that is the issue. It's because I only have 2015 installed.

[IonicaBizau]

@olivif Well, it aims to work with Visual Studio >= 2013. I'm thinking that maybe I should do it in the reverse way: if GraphicsMagic is not installed, then try to compile and use lwip. 😁

[olivif]

that could work 😄

[IonicaBizau]

@olivif I did it! There we go:

Don't forget to tell Microsoft to enable 16 million colors in Command Prompt. 😂

Here's how it works: lwipify uses lwip2. lwip2 checks if GM is installed and if not it tries to install lwip.

image-parser takes care of parsing the image (using lwip or gm, doesn't matter).

[olivif]

niiiiiice!!! 😄