Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring Inertial Parameters & Improvements Needed #100

Open
3 tasks
Ipuch opened this issue Oct 13, 2023 · 0 comments
Open
3 tasks

Refactoring Inertial Parameters & Improvements Needed #100

Ipuch opened this issue Oct 13, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@Ipuch
Copy link
Owner

Ipuch commented Oct 13, 2023

While working on refactoring the inertial parameters, I've realized and acted upon some inadequacies in how I initially coded the segments. After addressing concerns raised by @ANaaim in #96, I've managed to improve the code. Here's a brief of what I've done and what's still pending.

I've added methods to easily set inertial parameters at the segment level in #99
Example:

biomechmodel["thigh"].set_inertial_parameters(mass=..., center_of_mass=..., inertia_matrix=..., transformation_matrix_type=...)

Pending Tasks:

  • Implement methods for the entire biomech model, e.g., Biomech.set_inertia_parameters(segment_name=..., ...). This method should also update the mass matrix.
  • Create links between the model creator and these new methods to allow direct value specification.
  • Introduce functions related to inertial parameters (from anthropometric tables) that can auto-adjust based on segment length during model creation. This will eliminate the need to manually input these values.
@Ipuch Ipuch added the enhancement New feature or request label Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant