Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect rendering of running water on ice #1476

Closed
ZechariahB opened this issue Jun 8, 2022 · 4 comments
Closed

Incorrect rendering of running water on ice #1476

ZechariahB opened this issue Jun 8, 2022 · 4 comments
Labels
bug Something is implemented incorrectly

Comments

@ZechariahB
Copy link

What happened?

Ice is rendered see though when running water is placed on top. Additional various water sources nearby will create a visible 16 x 16 grid where the sides of water render ice. Water source blocks seem to not have this issue.

Screenshots

Screenshot_20220608_015937

Relevant log output

No response

Minecraft Version

1.19

Iris Version

iris-mc1.19-1.2.5

Sodium Version

sodium-fabric-mc1.19-0.4.2+build.16

Operating System

KDE Plasma

What is your GPU?

Nvidia GeForce RTX 3050 Ti

Java Version

Java 16

Additional context

No response

@ZechariahB ZechariahB added the bug Something is implemented incorrectly label Jun 8, 2022
@LordVertice
Copy link

Pretty sure this is related: with any shaders active, water cannot be seen through glass, and glass cannot be seen through water.

2022-06-09_14 50 40
Didn't take a screenshot of it, but when I enter that glass cage, the entire ocean floor becomes visible due to the water not rendering at all. Likewise, diving below the ocean surface makes all glass blocks seemingly disappear. I can provide more screenshots or logs if needed.

@ZechariahB
Copy link
Author

I'm wondering if this is an old bug or a recent one. Does 1.18 -> 1.17 Iris and Sodium have this same rendering bug? Additional images of these occurrences is appreciated to help understand the full scope of this issue.

@LordVertice
Copy link

Alright, so the issue is 100% reproducible on 1.17.1. However, I believe there may be 2 different issues happening here. OP's ice related issue happens on Sodium with and without Iris and is tracked here: CaffeineMC/sodium-fabric#1286 but seems to be caused by CaffeineMC/sodium-fabric#38

This may or may not be what's causing some shaders to go nuts over water and stained glass (see my previous comment), since issue 38 is tracking a variety of different translucency related issues caused by the same underlying problem, however this in particular only shows up when using Iris shaders. Perhaps there's still something that can be done on Iris' end? If not, this is up to Sodium's devs.

Here are some more screenshots: https://imgur.com/a/qTyizdN

@coderbot16
Copy link
Member

coderbot16 commented Jun 15, 2022

This seems to just be a case of Sodium's infamous translucency sorting issues, so I will be closing this issue since there's nothing to be done on the Iris side to fix it.

The issue with stained glass and water in the comment is a limitation specific to deferred-rendered shader packs and there is nothing that Iris can do about it. Shader packs like Complementary Shaders use forward rendering and are not affected by that issue, but are still affected by Sodium's issue.

You can tell the difference between Sodium's translucency sorting issues happen within a chunk, but deferred rendering translucency issues happen with all translucent surfaces, even between chunks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is implemented incorrectly
Projects
None yet
Development

No branches or pull requests

3 participants