Daylight saving fix: The default dart DateTime object caused incorrect week startday data. #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
object automatically accounts for daylight savings and by doing so, returned incorrect dates. For example if I would go from the week of 19 okt 2020 to the week of 26 okt 2020 it would display the week starting at sunday 25 okt. 25 okt 2020 23:00 to be exact. DateTime.utc() does not account for daylight savings so I just had to swap some default constructors with UTC constructors.
|
Any prediction when this will be merged and released? |
|
No I don't know the author. My last pr got merged pretty quickly but it's anyone's guess really. Sorry :/ |
|
@RobbeDGreef Thanks for the pull request which fixes that bug. I've merged it. |
|
@IronLad85 thanks! |
Milvintsiss
pushed a commit
to Milvintsiss/flutter_calendar_strip
that referenced
this pull request
Feb 13, 2021
Daylight saving fix: The default dart DateTime object caused incorrect week startday data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DateTime object automatically accounts for daylight savings and by doing so,
returned incorrect dates. For example if I would go from the week of
19 okt 2020 to the week of 26 okt 2020 it would display the week starting
at sunday 25 okt. 25 okt 2020 23:00 to be exact. DateTime.utc() does not
account for daylight savings so I just had to swap some default
constructors with UTC constructors.