Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save window geometry in global instead of local storage #34

Closed
shssoichiro opened this issue Aug 3, 2022 · 2 comments · Fixed by #60
Closed

Save window geometry in global instead of local storage #34

shssoichiro opened this issue Aug 3, 2022 · 2 comments · Fixed by #60
Labels
bug Something isn't working enhancement New feature or request

Comments

@shssoichiro
Copy link
Contributor

This is potentially related to #21, but I wasn't sure how much it overlapped so decided to create a new issue.

I think the common workflow is that most people want to have their vspreview window in the same location for each video file they're working on, rather than having it reset to the default location for each new file. Having to move the window each time is a minor annoyance rather than a significant issue, but it would be more convenient, in my opinion, to have the geometry saved globally rather than per file.

@Setsugennoao
Copy link
Member

Thanks for opening the issue.
I made the window settings (timeline, window geometry, window state) part of the global state in #5d04108.

@shssoichiro
Copy link
Contributor Author

It doesn't seem to be working correctly, for me at least. I see that the window settings are saved in the global config, but when I reopen vspreview, the window position is at the default. I'm using two monitors, in case this might have any effect on it?

@Setsugennoao Setsugennoao reopened this Aug 4, 2022
@Setsugennoao Setsugennoao added bug Something isn't working enhancement New feature or request labels Dec 6, 2022
@Setsugennoao Setsugennoao linked a pull request Dec 10, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants