Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scene Tool Crashing #62

Closed
Jumaron opened this issue Dec 28, 2022 · 1 comment · Fixed by #65
Closed

Scene Tool Crashing #62

Jumaron opened this issue Dec 28, 2022 · 1 comment · Fixed by #65

Comments

@Jumaron
Copy link

Jumaron commented Dec 28, 2022 •
edited

Hello when i tried to use it it crashes with two crashes.

CRASH: Traceback (most recent call last):
  File "C:\Program Files\Python310\lib\site-packages\vspreview\toolbars\scening\dialog.py", line 150, in on_label_changed
    index = self.tableview.selectionModel().selectedRows()[0]
IndexError: list index out of range

NEW CRASH:

Traceback (most recent call last):
  File "C:\Program Files\Python310\lib\site-packages\vspreview\main\timeline.py", line 272, in mouseMoveEvent
    QToolTip.showText(event.globalPosition(), notch.label)
TypeError: showText(QPoint, str, widget: QWidget = None, rect: QRect = {}, msecShowTime: int = -1): argument 1 has unexpected type 'QPointF'
@JustinTArthur JustinTArthur mentioned this issue Dec 30, 2022
Merged
@JustinTArthur
Copy link
Contributor

JustinTArthur commented Dec 30, 2022 •
edited

The first stacktrace looks to be from trying to set scene properties from the scene list without selecting a scene. Ultimately we should disable those controls until a scene is selected, but I've added code to ignore those controls sans-selection as a quick fix alongside the mouse-hover crash in PR #65.

Setsugennoao pushed a commit that referenced this issue Dec 31, 2022
@JustinTArthur
Fix scening toolbar after pyqt6 refactor (#65)
0d4752b 
* Fix crash when hovering cursor over scene notches in the timeline.

Was caused by the Qt6's float positioning needing conversion for tooltip text placement.
Stack trace found in #62.

* Fix crash when editing scene properties when no scene is actually selected.

This likely was a problem before the Qt6 refactor. The better solution
will be to disable these controls until a scene is selected or to have
all editing controls inside the table cells.
Stack trace found in #62.

* Fix crash when changing frames while scening.

SelectionFlag is a proper Python enum in PyQt6, replacing the custom
SelectionFlags class.

* Fix single frame scenes not persisting the label from the scening toolbar.

Issue likely existed prior to PyQt6 refactor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix recent Scening toolbar and workflow issues
2 participants
@JustinTArthur @Jumaron