Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recent Scening toolbar and workflow issues #65

Merged
merged 4 commits into from Dec 31, 2022
Merged

Fix recent Scening toolbar and workflow issues #65

merged 4 commits into from Dec 31, 2022

Conversation

JustinTArthur
Copy link
Contributor

This fixes the following crash scenarios:

  • Hovering cursor on timeline scene notch.
  • Browsing to new frames while there are listed scenes.
  • Editing scene properties in the scene list dialog despite no scene selected.

It also fixes the scene label not being added for single-frame scenes. Some of these issues were caused by the PyQt6 refactor, but a couple were present beforehand.

Fixes #62.

Was caused by the Qt6's float positioning needing conversion for tooltip text placement.
Stack trace found in #62.
…ected.

This likely was a problem before the Qt6 refactor. The better solution
will be to disable these controls until a scene is selected or to have
all editing controls inside the table cells.
Stack trace found in #62.
SelectionFlag is a proper Python enum in PyQt6, replacing the custom
SelectionFlags class.
…lbar.

Issue likely existed prior to PyQt6 refactor.
@JustinTArthur JustinTArthur mentioned this pull request Dec 30, 2022
@Setsugennoao Setsugennoao merged commit 0d4752b into Jaded-Encoding-Thaumaturgy:master Dec 31, 2022
@JustinTArthur JustinTArthur deleted the fix-qt6-refactor-scening-issues branch December 31, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scene Tool Crashing
2 participants