Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade PHP 7 to 8 due to new warnings in Drupal 9 about deprecated PHP #267

Closed
g7morris opened this issue Dec 1, 2022 · 4 comments
Closed

Comments

@g7morris
Copy link
Contributor

g7morris commented Dec 1, 2022

As written on the tin: Please consider upgrading PHP 7 to 8 due to new warnings (as of 11/30/22) in Drupal 9 about deprecated PHP.

Here is an example screenshot from the Status Report of a site running ISLE-DC with Nginx 1.18.0, Drupal 9.4.8 & PHP 7.4.26

Screenshot 2022-11-30 at 4 27 29 PM

The current nginx service Dockerfile for the indicates php7 is in use. (this is expected)


I fully anticipate that we should possibly make this into a release / sprint of its own @nigelgbanks given the potential for breakage across all Drupal modules.

We should also consider enlisting more testers etc e.g. maybe make it more formal?

Feels like we could plan for a Jan / Feb release.

Is this something we should bring to the weekly Islandora Tech meeting?

Would love your thoughts, ideas on this when you have a chance. Cheers!

@misilot
Copy link
Contributor

misilot commented Dec 1, 2022

#238 should address this when it's ready

@g7morris
Copy link
Contributor Author

g7morris commented Dec 1, 2022

@misilot Understood but that ticket doesn't seem to be very specific about its intent. Additionally we don't know what breaking changes or impact an upgrade to PHP 8 will have on Drupal Modules. I'm recommending to @nigelgbanks to make it a more formal breaking release and to invite the community for a sprint and testing as an idea.

Would that be something you're interested in helping with too?

@misilot
Copy link
Contributor

misilot commented Dec 1, 2022

I would be happy to do some testing, once I can get our custom codebase working on a new install.

@nigelgbanks
Copy link
Contributor

Done under #238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

3 participants