Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We aren't testing all of islandora's submodules #1390

Closed
dannylamb opened this issue Dec 18, 2019 · 1 comment
Closed

We aren't testing all of islandora's submodules #1390

dannylamb opened this issue Dec 18, 2019 · 1 comment

Comments

@dannylamb
Copy link
Contributor

We're only running tests for breadcrumbs. We need to run them for all the derivative submodules as well. I bumped into this making a test for islandora_video and turns out they're failing (at least for that submodule), so there'll have to be some cleanup on those tests too once we turn them on.
@dannylamb dannylamb mentioned this issue Dec 18, 2019
Merged
@whikloj
Copy link
Member

whikloj commented Dec 19, 2019

Resolved with Islandora/islandora@20477e8

@whikloj whikloj closed this as completed Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@whikloj @dannylamb