Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] File access is not ensured before attempting to use them in IIIF/OpenSeadragon #2134

Closed
adam-vessey opened this issue Jul 14, 2022 · 2 comments
Labels
Type: bug identifies a problem in the software with clear steps to reproduce

Comments

@adam-vessey
Copy link
Contributor

adam-vessey commented Jul 14, 2022

What steps does it take to reproduce the issue?

  • When does this issue occur?

This was encountered when setting a "file"-level embargo using the dgi's fork of the embargoes module; however, any other mechanism to constrain access to particular file entities would similarly cause it to happen.

  • Which page does it occur on?

Viewing images/paged content which make use of IIIF manifests where the current user does not have access to to the file entities referenced from the media selected for use in the displays.

  • What happens?

Broken viewers are shown, with 403 errors emitted to browser consoles (and presumably to Drupal's watchdog logs).

  • To whom does it occur (anonymous visitor, editor, administrator)?

Those without access to the referenced files.

  • What did you expect to happen?

Viewers would not be visible or not attempt to render elements for entities to which the user does not have access.

Which version of Islandora are you using?

2.4.0

Any related open or closed issues to this bug report?

Unknown; though, here's a number of PRs addressing things:

Screenshots:

@seth-shaw-asu
Copy link
Member

Anything else, @adam-vessey?

@adam-vessey
Copy link
Contributor Author

adam-vessey commented Sep 1, 2022

Nah, that was it... except... I guess, releases of the two things, islandora and openseadragon? Drafted... sane (assuming they're visible)?:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: bug identifies a problem in the software with clear steps to reproduce
Projects
None yet
Development

No branches or pull requests

2 participants