Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace islandora_defaults with an exported site islandora-starter-site #2

Closed
lutaylor opened this issue Aug 30, 2022 · 4 comments
Closed

Comments

@lutaylor
Copy link

lutaylor commented Aug 30, 2022

Overview

Intial work to replace https://github.com/Islandora/islandora_defaults with an exported site in a project housed in this repository https://github.com/Islandora/islandora-starter-site/.

The intent is to simplify expectations and maintenance. This is to help facilitate the communities end goal to modularize Islandora into largely independent Drupal modules that let Drupal sites pick and choose their repository features.

The structure of the example site could look like:

https://github.com/Islandora/islandora-starter-site/

-composer.json / composer.lock
-config/sync
-content/sync

Acceptance Criteria
-We have an islandora_defaults replacement exported starter site.
-Current enabled islandora_default functionality as installed with the Islandora Playbook in Olivero is present.
-README should contain instructions on how to manually utilize the starter-site outside of ISLE/playbook. README should specify awareness for existing sites.

Out of Scope
Removing islandora_defaults from existing sites

Reference
https://docs.google.com/document/d/1fx8PvSpft8c3OPMLrN5SjaqOhcHOuRr_xjgqnBe8gg4/edit#heading=h.w3w654y9wz7s

Contacts
On Islandora slack
Rosie Le Faive (Product owner)
Luke Taylor (Project Manager)

@rosiel
Copy link
Contributor

rosiel commented Aug 30, 2022

Code cutoff is of commit 7b34ad2. Commits to Defaults after that (which affect functionality!) will need to be made separately on this repo

@adam-vessey
Copy link
Collaborator

adam-vessey commented Aug 31, 2022

Just a note: Work had been started (#1) at the presently-latest release of 2.1.1 of islandora_defaults... Looking at the diff between it and the present unreleased HEAD of 7b34ad2: Islandora/islandora_defaults@2.1.1...7b34ad2 ... is fairly small stuff, pretty much:

  • The Drupal version compatibility assertions (dropping 8)
  • The resources_types URI change for the "Collection" term; and,
  • The changing of the condition plugin in the repository_content context

... Notably, don't presently have an analog for existing action/CI workflow, as it has the project baked in and the like, which would require some reworking to use with this starter site approach.

@adam-vessey
Copy link
Collaborator

Looks like I had already had the "Collection" term URI updated (slight goof in workflow having made it easier to grab the file from Github... which resulted in me grabbing it from islandora_defaults's HEAD, instead of from the 2.1.1 release).

Otherwise, effected the other two changes between https://github.com/Islandora/islandora-starter-site/pull/1/files/e4ef87debd5a755d01172cdb12dcc57e585c8d3c..4f94206d456f54c8fafc55275d2b425599f5b962

@rosiel
Copy link
Contributor

rosiel commented Dec 2, 2022

The replacement for Defaults has been completed.

@rosiel rosiel closed this as completed Dec 2, 2022
rosiel pushed a commit that referenced this issue Mar 2, 2023
Fix port from showing in identifier, and add descriptions.

Thank you.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants