Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Dockerfile #43

Merged
merged 8 commits into from Apr 12, 2019
Merged

Added Dockerfile #43

merged 8 commits into from Apr 12, 2019

Conversation

magicalyak
Copy link
Contributor

@magicalyak magicalyak commented Apr 10, 2019

This PR adds a dockerfile so you can run the following and see the app on Docker (replace magicalyak with your dockerhub name)
docker build --rm -t magicalyak/angular7-example-app .
docker run --rm -d -p 80:80/tcp magicalyak/angular7-example-app

@coveralls
Copy link

coveralls commented Apr 10, 2019

Pull Request Test Coverage Report for Build 644

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.94%

Totals Coverage Status
Change from base Build 642: 0.0%
Covered Lines: 326
Relevant Lines: 366

💛 - Coveralls

@Ismaestro Ismaestro merged commit 9924fa3 into Ismaestro:master Apr 12, 2019
@Ismaestro
Copy link
Owner

Thanks very much @magicalyak!

@magicalyak
Copy link
Contributor Author

Thank you! I was looking for a good demo website and your creation is great! The container was fun to build. It uses one image to build everything and the final container is just the site (so it’s pretty lightweight) thanks again!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants