Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering issues (apparently depth) #137

Closed
ghost opened this issue Jun 10, 2017 · 8 comments
Closed

Rendering issues (apparently depth) #137

ghost opened this issue Jun 10, 2017 · 8 comments

Comments

@ghost
Copy link

ghost commented Jun 10, 2017

http://israelhiking.osm.org.il/#!/18/32.6855/35.0791

3 buildings are green due to being near a national park boundary.

http://israelhiking.osm.org.il/#!/17/32.6831/35.0871

Name rendering below a way.

@HarelM
Copy link
Member

HarelM commented Jun 10, 2017

Can you add a screen shot, I don't see an issue with building being green - the green part in the below screenshot is grass.
Also it will be better to open two separate issue since what you describe is two unrelated bugs.
I don't see the name below a way bug though:
image

@ghost
Copy link
Author

ghost commented Jun 10, 2017

This is not the place I sent, and the fact that you saw a different place could be #138. I will provide a screenshot.

Also it will be better to open two separate issue since what you describe is two unrelated bugs.

I don't know the code and you might be right, but to me both seem nearly identical depth tuning issues. Case 1, buildings render below boundary. Case 2, text renders below way.

@ghost
Copy link
Author

ghost commented Jun 10, 2017

1

screenshot from 2017-06-10 17-52-09

2

Here are the images. To locate the place, you can use the coordinates in the first post, or search for "מצפור טייסת העמק". The buildings are slightly west of the Metspor.

@HarelM
Copy link
Member

HarelM commented Jun 10, 2017

Can you make a screen shot of the right layers pane? The second issue might be because you have the ihm trails overlay enabled...?

@ghost
Copy link
Author

ghost commented Jun 10, 2017

Can you make a screen shot of the right layers pane? The second issue might be because you have the ihm trails overlay enabled...?

You're right! It was enabled. My bad. The building issue remains, though.

As an aside UX note, I see no point in allowing that layer to be enabled when the "מפת הטיולים הפתוחה" is enabled.

@HarelM
Copy link
Member

HarelM commented Jun 10, 2017

As an aside UX note, I see no point in allowing that layer to be enabled when the "מפת הטיולים הפתוחה" is enabled.

I agree, It's not an elegant or easy fix though.

I'm not sure there's something we can do with the buildings since we decided it's important to see the end of the natural reserve more than seeing the building, keeping this issue open though since I agree it's a problem.

@zstadler
Copy link
Member

Extending on @HarelM above, the wider part of the Nature Reserve's boundary is semi-transparent in order to keep other map elements visible. In fact, it seems to work since you understood that there was an overlap of the boundary with buildings.

Would you prefer that buildings and potentially other map elements would hide Nature Reserves' boundaries?

@ghost
Copy link
Author

ghost commented Jun 10, 2017

it seems to work since you understood that there was an overlap of the boundary with buildings.

Some buildings are totally green and look as if they're a different feature. (see bottom right building in first picture). I believe buildings should be rendered above the the boundary. Or maybe: Boundary's outermost line renders above buildings, but the boundary's "inner shade" renders below. If that's technically possible.

Regardless, there's no serious confusion and this is a minor and low priority issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants