Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

routeLoaded event details missing route params #190

Closed
spooky opened this issue Jan 28, 2021 · 6 comments
Closed

routeLoaded event details missing route params #190

spooky opened this issue Jan 28, 2021 · 6 comments

Comments

@spooky
Copy link

spooky commented Jan 28, 2021

This is a feature request.
The router provides the nice params object with values resolved from the route template.
That object would come in handy as one of the event detail fields for the routeLoaded event (routeLoading as well if that's possible).

@ItalyPaleAle
Copy link
Owner

It might be doable. The params object would be read-write, so users (devs) could modify the state of the app from that. Which might or might not be desirable.

What is your use case?

@spooky
Copy link
Author

spooky commented Mar 2, 2021

Not a very critical one - setting page title based on route and it's params ;)

@ItalyPaleAle
Copy link
Owner

Why not doing that in the component itself?

@spooky
Copy link
Author

spooky commented Mar 3, 2021

I am, but I'd rather have it in the router.

@JestDotty
Copy link

JestDotty commented May 23, 2021

I'm trying to figure out page breadcrumbs right now and this feature would make it possible I think

edit: just ended up doing something custom with $location

@ItalyPaleAle
Copy link
Owner

Fixed in the master branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants