Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11.3.3 No Core folder? #22

Closed
timothyallan opened this issue Mar 1, 2019 · 12 comments
Closed

11.3.3 No Core folder? #22

timothyallan opened this issue Mar 1, 2019 · 12 comments

Comments

@timothyallan
Copy link

Heya, just updated to 11.3.3 and get this on compile now:

./node_modules/three-full/sources/renderers/webgl/WebGLGeometries.js
Module not found: Can't resolve '../../core/BufferAttribute.js' in '/Development/project/node_modules/three-full/sources/renderers/webgl'

Peeked in the sources folder, and it seems like /core isn't in there anymore! 11.3.2 worked great.

@timothyallan timothyallan changed the title 11.3.2 No Core folder? 11.3.3 No Core folder? Mar 1, 2019
@webprofusion-chrisc
Copy link

Confirming this bug is present in 16.0.0 as well. The issue appears if you just use three-full to pull in examples like:

import { EquirectangularToCubeGenerator } from "three-full/sources/loaders/EquirectangularToCubeGenerator";

@Itee
Copy link
Owner

Itee commented Mar 3, 2019

Mmmhh this is really weird ! All seems to work fine... I clearly saw the core folder in latest version.

@webprofusion-chrisc About EquirectangularToCubeGenerator this class is not exported by EquirectangularToCubeGenerator file only CubemapGenerator... I will fix it.

@Itee
Copy link
Owner

Itee commented Mar 3, 2019

What bundler are you using ?

Using rollup i clearly see that BufferAttribute is include in WebGLGeometries.test.

Have you any kind of template to reproduce this issue ?

@webprofusion-chrisc
Copy link

@Itee this is within an Ionic 4 app which is Angular 7 and TypeScript 3.x using webpack.

@timothyallan
Copy link
Author

That IS strange. I just installed 16 via npm install --save three-full and my node_modules/three-full folder is definitely missing sources/core. It's just a typescript project using create react app.

screen shot 2019-03-03 at 9 09 58 am

@timothyallan
Copy link
Author

and 11.3.2 using the same method...
screen shot 2019-03-03 at 9 58 57 am

@Itee
Copy link
Owner

Itee commented Mar 3, 2019

Wow this is so strange o_O !

The "core" folder is in sources. So except that npm publish filter the core folder i don't understand what happening here.

Currently the only work around that i see is to copy paste the core folder from github in your npm module... This is not maintainable but could help waiting a fix or better solution...

@Itee
Copy link
Owner

Itee commented Mar 3, 2019

In npm run kit (under v15.0.0) i can create BufferAttribute so the core module is in v15.0.0 at least.

@Itee
Copy link
Owner

Itee commented Mar 3, 2019

OMFG !!! I found why...

I upgrade my NPM to v6.8.0 and... BAM

Could you try the fix under v16.0.1 ?

@timothyallan
Copy link
Author

timothyallan commented Mar 3, 2019

Amazing find! I just installed again from scratch, which gets me 17, and there's our friend the core folder :)

Edit: 16.0.1 seems to be fixed as well

@Itee
Copy link
Owner

Itee commented Mar 3, 2019

Thanks for the feedback !

Ok so could i/you close ?

@timothyallan
Copy link
Author

Thanks for making this library! ;)
Done and closed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants