Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posibility to specify nuget download url #43

Closed
vitia opened this issue May 29, 2016 · 9 comments
Closed

Posibility to specify nuget download url #43

vitia opened this issue May 29, 2016 · 9 comments

Comments

@vitia
Copy link

vitia commented May 29, 2016

I'd like posibility to override nuget download web url (for offline builds) which currently is hardcoded in BaseNuGet exec:
def nugetUrl = "https://dist.nuget.org/win-x86-commandline/v${project.extensions.nuget.version}/nuget.exe"
It would be cool to be able to provide own url like this:
nuget {
nugetUrl ="http://cache.local/nuget/3.3.0/nuget.exe"
}

@gluck
Copy link
Contributor

gluck commented May 30, 2016

Would be nice indeed, feeling like contributing it ?

@admsteck
Copy link

admsteck commented Jun 2, 2016

I've just started looking at gradle and would be happy to contribute a fix for this as well as allowing you to use 'latest' as the nuget version. The only problem is that I am not sure how to test my changes locally before submitting the pull request.

@timotei
Copy link
Contributor

timotei commented Jun 2, 2016

@admsteck You can either create some tests in Specs we have so far, or, make a test project where you use the plugin and configure it like you want (In order to use the modified version you either install it locally, or do a buildSrc symbolic link - see more info https://docs.gradle.org/current/userguide/custom_plugins.html)

@admsteck
Copy link

admsteck commented Jun 2, 2016

Thanks @timotei. I went with the buildSrc option and confirmed that it uses the nugetUrl provided.

@vitaliusvs
Copy link

vitaliusvs commented Jun 30, 2016

Appears that urls are case sensitive - this one opens fine:
https://dist.nuget.org/win-x86-commandline/v3.4.4/NuGet.exe

However plugin builds lowercase url which fails:
https://dist.nuget.org/win-x86-commandline/v3.4.4/nuget.exe

<Error>
<script/>
<Code>BlobNotFound</Code>
<Message>
The specified blob does not exist. RequestId:c6e5ef4b-0001-00d5-2cc8-d284b0000000 Time:2016-06-30T12:08:39.0913813Z
</Message>
</Error>

@gluck
Copy link
Contributor

gluck commented Jul 8, 2016

Seems the lowercase url works for <3.4.4 versions (tested with 3.4.3, both lowercase and cased urls work).
nUgEt is such a troll :trollface:

@gluck
Copy link
Contributor

gluck commented Jul 8, 2016

actually no, needs to be lowercase for <3.4.4 and cased for >=3.4.4
:trollface:

@gluck
Copy link
Contributor

gluck commented Jul 8, 2016

see #48

@imanushin
Copy link
Contributor

@vitia, @gluck, change was done in this PR: #62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants