Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add database support #22

Closed
ItsDrike opened this issue Jul 20, 2024 · 1 comment · Fixed by #35
Closed

Add database support #22

ItsDrike opened this issue Jul 20, 2024 · 1 comment · Fixed by #35

Comments

@ItsDrike
Copy link
Owner

We'll definitely need a database for the bot as we go on, we'll need to add support for it. Most likely, just using sqlite will be enough here and it will make it a lot easier for everyone involved when compared to having to work with a full dbms, like postgresql.

Question is whether or not we'll also want to do ORM (sqlalchemy) or just write some simple crud classes, or work directly with SQL everywhere. As much as I like sqlalchemy, it's probably a bit too involved and complex for us now. As for writing SQL directly, that could lead to issues and is probably more complex than just exposing some basic crud classes that everyone can use even without being familiar with SQL.

@ItsDrike
Copy link
Owner Author

After some discussions, we'll go with SQLAlchemy after all, mainly due to the possibility of using alembic for db migrations, which would be pretty annoying to have to handle manually. For the backend, we'll still go with sqlite though, to avoid everyone having to have a database that can can connect to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant