Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intensity based registration module #1188

Closed

Conversation

alfonsosanchezbeato
Copy link

These classes implement a module for OpenCV for parametric image registration. The implemented method is direct alignment, that is, it uses directly the pixel values for calculating the registration between a pair of images, as opposed to feature-based registration. The implementation follows essentially the corresponding part of the paper "Image Alignment and Stitching: A Tutorial", from Richard Szeliski.

More information can be found in the module's documentation.

@ivan-korolev
Copy link
Contributor

@LeonidBeynenson Leonid, could you please review?

@kirill-korniakov
Copy link

It was a right decision to create a new module, since it fully compiles to the new "micromodule architecture".

It seems to me that we should put such a giant contribution to an extra module. Even if the module is perfect today, we should be sure that it will be supported in future. But the OpenCV team can't promise that, so we will probably create a separate folder/repo for extra modules. That will mean that they are semi-official, and they become the official ones if only they are stable and popular enough...

Let us discuss this topic, and get back to you. @alfonsosanchezbeato, right now you can continue to develop your module as you want.

@alfonsosanchezbeato
Copy link
Author

No problem, just let me know your decision when you take it.


De: Kirill Kornyakov notifications@github.com
Para: Itseez/opencv opencv@noreply.github.com
CC: alfonsosanchezbeato alfonsosanchezbeato@yahoo.es
Enviado: Lunes 5 de agosto de 2013 9:39
Asunto: Re: [opencv] Intensity based registration module (#1188)

It was a right decision to create a new module, since it fully compiles to the new "micromodule architecture".
It seems to me that we should put such a giant contribution to an extra module. Even if the module is perfect today, we should be sure that it will be supported in future. But the OpenCV team can't promise that, so we will probably create a separate folder/repo for extra modules. That will mean that they are semi-official, and they become the official ones if only they are stable and popular enough...
Let us discuss this topic, and get back to you. @alfonsosanchezbeato, right now you can continue to develop your module as you want.

Reply to this email directly or view it on GitHub.

@alfonsosanchezbeato
Copy link
Author

Any news on this?

@kirill-korniakov
Copy link

Sorry, but no. Let's count months, not weeks. We don't have resources to setup a separate repository for testing of external modules, while we want to keep there large contributions like this one. We appreciate you help, but OpenCV has just a couple of fulltime devs, and they are not interested in image registration. So, let's wait when somebody else is available...

@kirill-korniakov
Copy link

@alfonsosanchezbeato, sorry for the late reply. We now have the repository for extra modules, so please propose your pull request for it: https://github.com/Itseez/opencv_contrib. Please note that you will be probably the first one, but actually most of the GSoC development will go there soon. And only when it matures, we'll add popular modules to the central repository.

@alfonsosanchezbeato
Copy link
Author

Thanks Kirill, I will do the pull when I have a bit of time.


De: Kirill Kornyakov notifications@github.com
Para: Itseez/opencv opencv@noreply.github.com
CC: alfonsosanchezbeato alfonsosanchezbeato@yahoo.es
Enviado: Miércoles 11 de septiembre de 2013 14:55
Asunto: Re: [opencv] Intensity based registration module (#1188)

@alfonsosanchezbeato, sorry for the late reply. We now have the repository for extra modules, so please propose your pull request for it: https://github.com/Itseez/opencv_contrib. Please note that you will be probably the first one, but actually most of the GSoC development will go there soon. And only when it matures, we'll add popular modules to the central repository.

Reply to this email directly or view it on GitHub.

@kirill-korniakov
Copy link

@alfonsosanchezbeato when working on your pull request, please check my comments here. It will possibly speedup the contribution process because I do not want to make you wait anymore... BTW, when you open your pull request to the opencv_contrib, please close this PR.

@mdim
Copy link
Contributor

mdim commented Oct 18, 2013

@alfonsosanchezbeato any progress?

@alfonsosanchezbeato
Copy link
Author

I have made a pull request to opencv_contrib:

opencv/opencv_contrib#5

@kirill-korniakov
Copy link

Great, thanks! Then I'll close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants