Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused macros from C headers #2680

Merged
merged 1 commit into from
May 19, 2014
Merged

Remove unused macros from C headers #2680

merged 1 commit into from
May 19, 2014

Conversation

adrians
Copy link
Contributor

@adrians adrians commented Apr 28, 2014

After grep-ing the code, I haven't found a single instance of them being used.
They look like being phased out a long time ago.

Also: It would be ok if I removed other strange chunks of code? Because I found this, and it's actually used in few places in the library.

#define OPENCV_CALL( Func )                                         \
{                                                                   \
Func;                                                           \
}

@adrians
Copy link
Contributor Author

adrians commented Apr 30, 2014

Also, I noticed that a portion of the library uses the define-and-goto based error handling (OPENCV_ERROR / CV_ERROR) while the other uses exceptions. It's ok to convert all of them to exceptions?

@SeninAndrew
Copy link
Contributor

@vpisarev , could you please comment on this?

@vpisarev
Copy link
Contributor

👍

@opencv-pushbot opencv-pushbot merged commit cbf3c1f into opencv:master May 19, 2014
vpisarev added a commit that referenced this pull request May 19, 2014
@adrians adrians deleted the remove_cv_err branch May 19, 2014 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants