fixed chi square distance formulae #3724
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The fix for the test for master(#3725) was pretty straightforward, but I cannot see where the test for 2.4 should be adapted. Anyone? |
added 2 commits
February 20, 2015 12:57
|
@vpisarev please look at it. |
|
@asmorkalov lets first see if we can fix the tests, there were some very sketchy solutions applied there :) |
|
Okay so now the code is uniform to the actual function BUT we now get accuracy problems from the tests So my question is how we can avoid this? |
|
Same as master branch, discussion was dealt with before, lets close this down! There is a double solution for now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing bug: http://code.opencv.org/issues/2199
Chi Square formulae is wrong defined