Added support for highgui module on WinRT 8.1+ #4155
Conversation
mkostin
force-pushed
the
highgui_contrib
branch
2 times, most recently
from
682d2c0
to
6168d0d
Compare
|
I'd like to kindly ask if this PR can be reviewed/merged by Tuesday next week (June 30). The reason is that there would be a period of unavailability afterwards and I wouldn't be able to respond to CRs and work on this PR. It's hard to tell how long would it last, so I'm looking to avoid the risk of eventually loosing this PR. Thank you in advance |
| @@ -29,6 +29,10 @@ file(GLOB highgui_ext_hdrs | |||
| "${CMAKE_CURRENT_LIST_DIR}/include/opencv2/${name}/*.hpp" | |||
| "${CMAKE_CURRENT_LIST_DIR}/include/opencv2/${name}/*.h") | |||
|
|
|||
| # Removing WinRT API headers by default | |||
| status(" ${name}: Removing WinRT API headers by default") | |||
There was a problem hiding this comment.
Remove this message.
It is too verbose on Linux, Android, iOS builds and actually on Windows. Try to use minimal set of messages.
There was a problem hiding this comment.
Done microsoft@4189929
|
In general, Looks good to me, 👍 Please squash 3rd and 1st commits to eliminate unnecessary changes from history (git history & git blame are powerful tools, but they require some commit policy) |
Signed-off-by: Maxim Kostin <v-maxkos@microsoft.com>
Signed-off-by: Maxim Kostin <v-maxkos@microsoft.com>
|
@alalek done, should be ready to go as soon as the builds get verified. |
|
@alalek Looks like builds have passed, are we good to go? |
|
Thanks! |
|
Thank you for prompt feedback, looking forward to having this merged :) |
Provides WinRT implementation for most of
highguiAPI except for keyboard and mouse events tracking. It enables using highgui quick preview and interaction API likenamedWindow(),imshow(),createTrackbar()etc. from Windows Runtime 8.1+ applications.Also updates existing
FaceDetectionsample to make use of highgui API.