-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plot Module #186
Plot Module #186
Conversation
Hi @vpisarev, this is my new module now in opencv_contrib. Hope it will be added to the repository. |
@@ -0,0 +1,6 @@ | |||
Plot - Module to Plot Data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the docs are now in Doxygen/Markdown format
…s 'show' and 'save'. Removed highgui dependency.
Hi @vpisarev, thanks for your input. I already made some of the changes you suggested. The biggest one is still missing though, to make the class follow the abstract interface - hidden implementation concept. |
…face - hidden implementation concept'.
@vpisarev, I am now uploading a new version where the class follows the concept you proposed. Hope it fills the requirements. |
@vpisarev, the new version of the module is already uploaded. Thanks. |
Hi @ilya-lavrenov, I am still waiting for a feedback for this new module, to know if there is something I need to change before it can be merged to the opencv_contrib repository. Thanks. |
@vpisarev I've already done the changes you suggested. Thanks! |
#ifdef __cplusplus | ||
|
||
#include <opencv2/core.hpp> | ||
#include <opencv2/imgproc.hpp> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like you may retain ony opencv2/core.hpp include in the header and move other include's to precomp.hpp. It will improve build speed
…des to precomp.hpp.
@vpisarev changes committed. |
@vpisarev is that anything else I have to do? |
@vpisarev are you considering to add this module to the repository or is there something I have to change? Thank you for your attention. |
Plot2dImpl(Mat _plotData) | ||
{ | ||
//if the matrix is not Nx1 or 1xN | ||
if(_plotData.cols > 1 && _plotData.rows > 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be a CV_Assert
. (as well as the ifs below)
@nmoutinho might be interesting for you: opencv/opencv#5386 |
@nmoutinho is it possible to have a look at the failed checks? This would enable us to fix everything and continue adding this. There is a new user base interested in this http://answers.opencv.org/question/73233/how-do-you-plot-graphs-in-opencv-projects/?comment=73401#comment-73401 |
Hi @StevenPuttemans, it is so cool that someone is interested in my Plot! I was waiting for your response since May (long time has passed...). I am a little busy now with my PhD thesis but as soon as I have time I will do all the changes required and hopefully we will get the Plot function in OpenCv. Thanks! |
That is great! Good luck with your PhD thesis, and hoping to hear soon from you! |
@nmoutinho, sorry for a huge delay! let's finally put it in 👍 |
@vpisarev w00t w00t, I have the impressions you guys are doing a huge job at finally merging everything? |
Thanks a lot @vpisarev ;) I really hope people like it. It still has a lot to improve but it's a good start. |
Is there a Python API available as well? |
Since there is not a single |
I'm currently a little occupied. I'll try and get back to this sometime next month. |
…#186) - drop `v0` namespace
Created a Plot2D Module which allows you to easily plot data from a Mat. You can plot 1D or 2D plots, change the window size, the axis limits and the colors of all the elements.
In C++, you just have to do:
and that's it.
These are two examples of functions being plotted:
![sin_x](https://cloud.githubusercontent.com/assets/9116444/6652336/5ea0c9dc-ca63-11e4-81fa-7b5dfc1ee0cf.png)
sin(x)
x^2
![x_2](https://cloud.githubusercontent.com/assets/9116444/6652345/661dba4e-ca63-11e4-86bc-0c4a74388b5d.png)