Implement image hash modules #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 : add overload functions
2 : forgot to include iostream
1 : Fix wrong branch 2 : Add another solution to download img_hash
|
@stereomatchingkiss , I've refactored interfaces and simplified the documentation. Please take a look: master...mshabunin:img_hash If you like it you can pull this commit to your branch: opencv_contrib> git checkout img_hash
opencv_contrib> git pull https://github.com/mshabunin/opencv_contrib img_hash |
|
Thanks for your contribution :), please give me some times to study your
codes.
2017-05-25 16:21 GMT+08:00 Maksim Shabunin <notifications@github.com>:
… @stereomatchingkiss <https://github.com/stereomatchingkiss> , I've
refactored interfaces and simplified the documentation. Please take a look:
master...mshabunin:img_hash
<master...mshabunin:img_hash>
If you like it you can pull this commit to your branch:
opencv_contrib> git checkout img_hash
opencv_contrib> git pull https://github.com/mshabunin/opencv_contrib img_hash
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#688 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABt-up--UrRicwNyaBQycorjCIc8YySKks5r9TnvgaJpZM4IpP2u>
.
|
|
Sorry for my late reply, I study your codes and I have one request
Instead of using void* to implement pimpl, could you instead use type safe
solution to it?
I think this is safer and also easier to understand, I do not find much
benefits to implement pimpl
by void*.
class something
{
private:
struct pimpl;
cv::Ptr<pimpl> impl_; //I like unique_ptr better, but opencv still
using c++98
};
C++ pimpl avoiding void*
<https://stackoverflow.com/questions/35307934/c-pimpl-avoiding-void>
2017-05-26 7:57 GMT+08:00 ngap wei Tham <thamngapwei@gmail.com>:
… Thanks for your contribution :), please give me some times to study your
codes.
2017-05-25 16:21 GMT+08:00 Maksim Shabunin ***@***.***>:
> @stereomatchingkiss <https://github.com/stereomatchingkiss> , I've
> refactored interfaces and simplified the documentation. Please take a look:
> master...mshabunin:img_hash
> <master...mshabunin:img_hash>
>
> If you like it you can pull this commit to your branch:
>
> opencv_contrib> git checkout img_hash
> opencv_contrib> git pull https://github.com/mshabunin/opencv_contrib img_hash
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#688 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ABt-up--UrRicwNyaBQycorjCIc8YySKks5r9TnvgaJpZM4IpP2u>
> .
>
|
|
@stereomatchingkiss , I've updated my branch. |
|
Sorry for my late reply and thanks for your contribution :), I will try to
finish codes review on this weekend.
2017-06-05 17:46 GMT+08:00 Maksim Shabunin <notifications@github.com>:
… @stereomatchingkiss <https://github.com/stereomatchingkiss> , I've
updated my branch.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#688 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABt-ulH6OPCjkZ3BicH7IBNqKX06NMPuks5sA85wgaJpZM4IpP2u>
.
|
2 : use static cast to replace dynamic cast because class hierarchy of img_hash is very straightforward
|
@mshabunin Thanks for your contribute, I merge the pull request and change something, please inform me if I break something. ps : By the way, I think this branch is ready to merge into opencv_contrib. |
… this increase chance of breaking ABI
mshabunin
reviewed
Jun 20, 2017
There was a problem hiding this comment.
@stereomatchingkiss , looks good to me, thank you!
There is a compilation issue with scoped class declaration and I have one more comment related to the documentation.
| class CV_EXPORTS_W ImgHashBase : public Algorithm | ||
| { | ||
| public: | ||
| class ImgHashImpl; |
There was a problem hiding this comment.
This declaration should be moved back to the top level, on line 15. Otherwise the compilation would be broken.
There was a problem hiding this comment.
Sorry for the trouble, this problem is solved, I forgot to commit one file, that is why it cannot compiled
|
|
||
| ### Performance under different attacks | ||
|
|
||
|  |
There was a problem hiding this comment.
Could you please add this image and two in the next section to the img_hash/doc folder.
There was a problem hiding this comment.
Sure, will upload it on tomorrow
There was a problem hiding this comment.
Link should be changed to use local image:
… this increase chance of breaking ABI
…ber. pimpl only accessable by the class itself, therefore I think declare everything as public is quite safe
mshabunin
reviewed
Jun 21, 2017
| ### Speed comparison with PHash library (100 images from ukbench) | ||
|
|
||
|  | ||
|  |
There was a problem hiding this comment.
Please add these two images too.
|
|
||
| ### Performance under different attacks | ||
|
|
||
|  |
There was a problem hiding this comment.
Link should be changed to use local image:
|
👍 |
allnes
pushed a commit
to allnes/opencv_contrib
that referenced
this pull request
Jun 9, 2024
* remove ovms * update README * update root README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I intend to implement different image hashing algorithms and port the image hashing algorithms of PHash library to opencv. there are three algorithms already implemented by this pull request, they are "average hash", "phash" and "Marr-Hildreth Operator Based Hash".
Test case of average mean and phash are based on golden models(calculated by hand), test case of Marr-Hildreth Operator is based on the golden model compare with origin implementation(I make sure the steps of fillBlocks and createHash generate same value as PHash did).
In the future, I will port another algorithms from PHash library, like Radial Variance based Hash and block Mean Value Based Hash.