Compat for Create: Steam & Rails

[BLOKBUSTR]

I have already copied and modified some functions to support unpacking of a couple new minecarts provided by Create: Steam 'n' Rails. These carts include Crafting Tables and Jukeboxes. I wanted to discuss these additions in an issue first rather than coming out of the blue with a PR lol (especially since I have never performed a PR yet)

railways_minecart_unpacking_compat.mp4

I made all these new functions still under the minecartcrafting namespace. I decided to name my own functions in accordance with the minecart variants themselves, like benchcart and jukeboxcart, primarily to avoid confusion for myself.

Also, would it be possible to hide the recipe unlock toasts without breaking the advancement functions? I've tried setting show_toast to false, but for some reason the recipe just gives me the Knowledge Book item without triggering the associated function... The JSON formatting was completely fine too, yet this issue persisted even after reverting my changes. I'm not adept with scripting datapacks yet, so I don't know if there's something I'm doing wrong.

[Itsyourdriver]

Also, would it be possible to hide the recipe unlock toasts without breaking the advancement functions? I've tried setting show_toast to false, but for some reason the recipe just gives me the Knowledge Book item without triggering the associated function... The JSON formatting was completely fine too, yet this issue persisted even after reverting my changes. I'm not adept with scripting datapacks yet, so I don't know if there's something I'm doing wrong.

I'll mess around with it when I get the chance, I already have plans to clean up the pack soon so it's a good place to start.
Do you have the datapack files with your version so I can take a look at them?

[BLOKBUSTR]

I can fork this repository real quick, then drop all my new files in there for you to see. Shouldn't take too long 👍

[BLOKBUSTR]

Aight, here it is: https://github.com/BLOKBUSTR/unpackable-minecarts_compat-wip

I've named the functions according to the mod IDs and whatever blocks are being unpacked from the minecarts.

[Itsyourdriver]

Just got around to testing and I see what you mean, the main problem is that there is no show_toast for recipes. I tried it on the advancement which changed nothing. I also see that the chest minecart function is broken which is what you were experiencing with it persisting. Currently trying to figure out that function.