$consumer->toolProxy is not correctly decoded by DataConnector classes

[dac514]

I'm using your fork for an LTI Provider plugin i'm working on. Thanks for all your fixes and composer support. Very nice.

I need access to $consumer->toolProxy. In my database, AFAIK, lti2_consumer.tool_proxy is stored as a JSON string just like lti2_consumer.profile. Everywhere I see >toolProxy = I see:

$consumer->profile = json_decode($row['profile']);
$consumer->toolProxy = $row['tool_proxy'];

(Seen in: ToolProvider/DataConnector/DataConnector_mysql.php and ToolProvider/DataConnector/DataConnector_pdo.php)

One is coverted into an object, the other is not. I think it should be:

$consumer->profile = json_decode($row['profile']);
$consumer->toolProxy = json_decode($row['tool_proxy']);

Or maybe something like:

function isJson($string) {
 json_decode($string);
 return (json_last_error() == JSON_ERROR_NONE);
}
// ... snip ...
$consumer->profile = isJson( $row['profile'] ) ? json_decode( $row['profile'] ) : $row['profile'];
$consumer->toolProxy = isJson( $row['tool_proxy'] ) ? json_decode( $row['tool_proxy'] ) : $row['tool_proxy'];

What do you think?

PS: $consumer->toolProxy is declared dynamically. No stub in ToolProvider/ToolConsumer.php. This makes it harder to code because my IDE doesn't recognize that field. It would be nice to add it.

[Izumi-kun]

Whole project requires huge refactoring. Lot of classes not written completely and not used properly.

For example,

• toolProxy must be instance of \IMSGlobal\LTI\ToolProvider\MediaType\ToolProxy
• profile -> \IMSGlobal\LTI\ToolProvider\MediaType\ToolProfile
• \IMSGlobal\LTI\ToolProvider\MediaType\ToolProfile::$service_offered is array of \IMSGlobal\LTI\Profile\ServiceDefinition
• etc

I hope that this job can be done by me. But not soon because of free time deficit.

[dac514]

Thanks for the response. A thorough refactoring would be appreciated.