Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support linux appimage #2

Open
jopemachine opened this issue May 31, 2021 · 6 comments
Open

Support linux appimage #2

jopemachine opened this issue May 31, 2021 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@jopemachine
Copy link

jopemachine commented May 31, 2021

  • The target platform(s) the problem occurs on (Linux, Mac, Mac App Store, and or Windows): Linux
  • Node version (run node -v): 12.22.1
  • auto-launch version: 6.0.0
  • The options you're passing to auto-launch: hidden=true
  • Are you using NW.js or Electron? Electron
    • If so, which version?: Electron 12.0.1
    • If you're using Electron, are you using auto-launch from the main process or a renderer process? main-process
  • Can you reproduce this with a simple Hello World example app? No
  • If needs be, would you be able to provide us with a simple app (as simple as possible) which reproduces the problem? Yes

On Windows, and on Macos, easy-auto-launch works well.

But on Ubuntu using Appimage, easy-auto-launch launch below the screen (Electron) instead of my app.

캡처

I think maybe the below issue, PR in the original repo could be related to this issue.

Thanks for remaking the awesome library!

@Izurii
Copy link
Owner

Izurii commented Jun 1, 2021

The problem I see in creating an auto launch for AppImage is that the path to the AppImage can be changed anytime. What I think we can do is something like this: The user opens the AppImage this generate the autorun entry but if later the user change the location of the AppImage the autorun entry will be invalid, but once the user reopen the app using the AppImage the autorun entry will be updated with the new location.

@Izurii Izurii self-assigned this Jun 1, 2021
@Izurii Izurii added the bug Something isn't working label Jun 1, 2021
@jopemachine
Copy link
Author

jopemachine commented Jun 26, 2021

The problem I see in creating an auto launch for AppImage is that the path to the AppImage can be changed anytime. What I think we can do is something like this: The user opens the AppImage this generate the autorun entry but if later the user change the location of the AppImage the autorun entry will be invalid, but once the user reopen the app using the AppImage the autorun entry will be updated with the new location.

Yes, because the path changes whenever the mount is done (reboot), the previously registered path is invalid.

How about passing AppImage file path itself to Exec instead of process.execPath in linux?

[Desktop Entry]
Type=Application
Exec=/home/jopebot/Applications/Arvis-0.2.0.AppImage
Hidden=false
...

This works as expected, but the user needs to pass the AppImage file path manually,

And if the file path is changed by the user, the entry file will be invalid.

(So I'm not sure this is the right way though)

@uparlange
Copy link

uparlange commented Nov 7, 2021

Hi,

I have the same message auto launching my app (https://github.com/uparlange/bing-wallpaper) with Windows 11.

It is working good with Windows 10 and MacOS (BigSur and Monterey).

Capture d’écran 2021-11-07 090515
.

@ghost
Copy link

ghost commented Mar 3, 2022

Hello @Izurii,
Here is the fix: Netflix-Skunkworks/stethoscope-app@74ca61b

@ghost
Copy link

ghost commented Mar 3, 2022

@Izurii, the condition should be added here:

fixLinuxExecPath(): string | undefined {

Many thanks for this cleaner architecture!

@Izurii
Copy link
Owner

Izurii commented Mar 4, 2022

Hello @Izurii, Here is the fix: Netflix-Skunkworks/stethoscope-app@74ca61b

I'll be taking a look at that asap. Thank you for bringing a solution to this old bug :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants