Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with React 16 #108

Open
danyim opened this issue Oct 26, 2017 · 5 comments
Open

Incompatible with React 16 #108

danyim opened this issue Oct 26, 2017 · 5 comments

Comments

@danyim
Copy link

danyim commented Oct 26, 2017

I am getting the following error when attempting to use this library in my React 16 project:
Module not found: Can't resolve 'react-dom/lib/ReactCompositeComponent'

Does this project share the same technical reason why react-three-renderer can't support v16?
firtoz/react-three-renderer#197

@Izzimach
Copy link
Owner

Yeah, the rewrite of React for v16 changed a lot of internals. I don't have the free time I once did so the rewrite will be a long time coming. I should update the README.

@eeh
Copy link

eeh commented Dec 4, 2017

I had a reason to upgrade to React 16, and ran of course in to the above problem.

Any update? Anything I can do to help?

@danyim
Copy link
Author

danyim commented Dec 4, 2017

@eeh Rewrite the codebase to use Fiber :P But seriously, what would be best is to contribute to react-three-renderer as they're farther along in getting it implemented than this project.

@Izzimach
Copy link
Owner

Izzimach commented Dec 5, 2017

Yeah, R3R is pretty similar to react-three so you should be able to switch over and it looks like they are actively moving toward getting React 16 to work.

@wayofthefuture
Copy link

Can anyone recommend react-three-fiber versus react-three-renderer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants