Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

border and text color #27

Closed
ogansser opened this issue Apr 7, 2021 · 12 comments
Closed

border and text color #27

ogansser opened this issue Apr 7, 2021 · 12 comments
Assignees
Labels
bug Something isn't working

Comments

@ogansser
Copy link

ogansser commented Apr 7, 2021

Hi, thank you for the nice theme.

I want to change the color in the theme. bg and link is able to change. border and text is always white no matter which color I use.

Thanx

@J-Siu
Copy link
Owner

J-Siu commented Apr 8, 2021

Thank you for reporting.

Border color was caused by missing css attributes in the box element.
Text color was caused by wrong variable name in template header file.

They are both fixed now. Please pull the master again and give it a try.

@J-Siu J-Siu added the bug Something isn't working label Apr 8, 2021
@J-Siu J-Siu self-assigned this Apr 8, 2021
@ogansser
Copy link
Author

ogansser commented Apr 8, 2021

Hi, thanks, how can pull the master did not clone the repository? I made a local project with blogdown::new_site(). Otherwise, make new_site and copy my posts and my config.yaml?

@ogansser
Copy link
Author

ogansser commented Apr 8, 2021

Second way work, bg color and text corol work. Thank you!

@J-Siu
Copy link
Owner

J-Siu commented Apr 8, 2021

Thank you for update!

May I close the issue?

PS: I think theme can be updated with install_theme() while specifying force = TRUE. (https://rdrr.io/github/rstudio/blogdown/man/install_theme.html)

@ogansser
Copy link
Author

ogansser commented Apr 8, 2021

Yes, thanks. Shortcode for youtube Video also does not work.

In config.yaml I wrote:
enableInlineShortcodes: true

In Rmd:
{{< youtube buiLez6AMU8 >}}

Watch the final site: http://gansser.de/post/choughs-verhaltenstypisierung/

@J-Siu
Copy link
Owner

J-Siu commented Apr 8, 2021

I checked your page, it maybe caused by missing space before the closing delimiter. As space is part of the shortcode delimiter.

Current:

{{< youtube id=“buiLez6AMU8”>}}

Try adding a space before >}}, like following:

{{< youtube id=“buiLez6AMU8” >}}

Ref: https://gohugo.io/content-management/shortcodes/#use-shortcodes

@ogansser
Copy link
Author

ogansser commented Apr 8, 2021

{{< youtube buiLez6AMU8 >}}

still does not work. Must be something different. I mad another site with another theme for my sister, there it works:

https://isigansser.netlify.app/post/ms/

@ogansser
Copy link
Author

ogansser commented Apr 8, 2021

HTML Site shows without space. In my Rmd there is a space. Strange.

Ein ausführliche Reportage des Bayerischen Rundfunks und Erläuterung der Vorgehensweise zu der Choughs-Typisierung gibt es hier:

Verhaltenstypen | Entwicklung und Anwendung

{{< youtube buiLez6AMU8 >}}

@J-Siu
Copy link
Owner

J-Siu commented Apr 8, 2021

Can you test your sister site with my theme?
Because the short code is working in my example site https://sk3.jsiu.dev/post/rich-content/ , and the md for that page is https://github.com/gohugoio/hugoBasicExample/blob/master/content/post/rich-content.md

@ogansser
Copy link
Author

ogansser commented Apr 8, 2021

how can I change the theme of a site?

@J-Siu
Copy link
Owner

J-Siu commented Apr 8, 2021

If you use git, go to root of your hugo site:

git clone https://github.com/J-Siu/hugo-theme-sk3 themes/sk3

Then in the config.toml file, look for the line theme = .... and change it to

theme = sk3

BTW, is your hugo up to date? The current hugo version is 0.82

@J-Siu
Copy link
Owner

J-Siu commented Apr 9, 2021

I created a RStudio testing project https://github.com/J-Siu/blogdown-sk3-test
I am able to see the embedded youtube video inside the viewer. So I am closing this for now.
Feel free to open a new issue if needed.

@J-Siu J-Siu closed this as completed Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants