New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Request] Auto Updater #5
Comments
I haven't looked into auto updating plugins yet, but I will soon. |
Version 1.6.0-RC 1 (In development branch https://github.com/J-Tanzanite/Little-Anti-Cheat/tree/development) now has auto-updating. |
I have issues with the auto update feature;
Version 1.6.0-RC 1 I had to disable Maybe I should install the Updater plugin? :D |
Yeah, I should have written it in the readme.md... Oops And yeah, maybe I should add a check to actually mare sure the updater is present before using it :'D A while ago you mentioned I should use SMAC's method of checking if a native is present.
|
I don't think that you should allow users to change the update URL. That's a huge security risk, and users can break this functionality completely. I would define the update url only in the source code: And you can check like this:
Code taken from: https://forums.alliedmods.net/showthread.php?p=2636300 |
I want server owners to be able to set their own URL with ease, and not having to update the source code. I wasn't sure what you mean by "That's a huge security risk"... Since you didn't tell me where the security issue lies (just that there is one, but no information about it), I took a break to think about it. ... I think this is what you are referring to. |
Why would you let users change the update URL of your plugin? This repo is the official one, and you are controlling your own updates. |
The original idea was that server owners could easily fork my project, and in their cfg/sourcemod/lilac_config.cfg file, set the update link to their own fork. Lets say that you had 30 servers, and you want to be able to update all of them with a single version of Lilac. As an example, lets say you are using version 1.6.0 in all your servers, and I've released version 1.7.0. Using a ConVar means that even if you pull directly from me, the CFG file will still have the link to your own fork and not mine, which means that you don't have to change the URL in the sourcecode before pulling from me. And yeah, when it comes to not trusting this official repo... If you do trust me, that's nice ^-^ You shouldn't trust random people online with direct access to your servers. That's the reasoning behind the ConVar controlling the URL. In terms of using your own fork for security reasons... |
Hmm, I would skip that fuss forking and compiling with a custom update URL every time you release an update. But I understand your point. |
I see. Oh, btw, does auto update actually work now? |
I just updated manually to 1.6.0-RC 4, and enabled update. So, see you at the next update! :D |
Sorry for the terribly late update, I've been moving as of late and haven't had much time or internet to work on Lilac. I am back now (sorta) and with a new update; Version 1.6.0-RC 5. Hopefully the auto-updater works as intended, and sourcebans++ & material-admin support should work much better now. I will not add more features now, and I will solely focus on bug fixes if any issues arise. I want version 1.6.0 to get released officially :P... As it's been a long time since my last official update. Looking forward hearing back from you on how this update works~ |
The update failed:
But regarding this post, it was probably a temporary GitHub down issue: I tried to run it manually with
|
That's kinda weird... I do have a new version tho, version 1.6.1-RC 5. Releasing that version now with those fixes, hopefully the updater works this time. |
I will wait, maybe the next update cycle will be successful. I will report back! |
Well, still no update, but I see the error now. Unfortunately it's in the So, these lines has errors: Replace the inner And check other syntax errors. |
Ohh I... Umm... I... ehh... Umm... How did I NOT notice that?! |
I fixed all the issues I could find, so the auto-update should work. |
Well, the updater is not updated ever since :( I had server restarts, but nothing. Maybe SteamWorks (the recommended for Updater) is causing it, I have updated it as well.
But it's still: I don't know what I'am is missing. Maybe try to not include new line at the Notes |
I removed the newlines, try now... |
Small update, because you were having issues with this, I tried to do it myself.
As you can see, it did download it, but it never refreshed the plugin. If it isn't working for you, then I suspect it really is just the updater plugin messing up somehow. |
I don't understand why isn't working. Are you using SteamWorks? |
Yes, however, I did recompile the binary myself. You see, when I installed the updater plugin, it told me I had to wait an hour before being allowed to check for updates... That's all I changed. |
First, I used the latest from here: http://users.alliedmods.net/~kyles/builds/SteamWorks/ I'am using the already compiled version downloaded from the original thread: https://forums.alliedmods.net/showthread.php?p=1570806 I now tried to compile myself, but multiple errors regarding SteamWorks, even with the updated syntax downloaded from here:
|
Due to the old syntax, I downloaded Sourcemod version 1.7 to my desktop, and compiled the binary there, and then put that compiled binary onto my server (which is running Sourcemod version 1.10). |
Well, I'am gonna stick to the manual update then... :D |
OOF. Anyway, since I managed to get auto-updater to work on my end but you didn't, I'm going to consider this issue half-solved. This is the last release candidate, and if no issues are reported on it within 2-5 days, it will get released as the official new version. c: |
Hmm, yes, the Updater is acting weird. Today I have received the updates. But in a strange form. The Updater thinks that every update is an Updater update :) Currently this is my update enabled plugins:
Check this logs:
After all it updated, because I see a new ban in my SourceBans++ :D
|
Awesome! But also... I might have to consider making my own updater plugin... What even... |
Version 1.6.0 is now official. However, when I merged the changes, I made a mistake and updated the development version... Accidentally changing the update URL to the main branch. I fixed it now, but thought I'd tell you in case it messed with your server. |
I'am not going to use the Updater plugin, because it's messing up some of the Updater enabled plugins:
After server restart:
I will stick to the manual update until the official author releases a new version fixing all the issues. It looks like the original version of the Updater plugin is unreliable. And I'am not going to use 3rd party fixes. I'am fine with the manual updates. |
Going to close this as auto update has been implemented. |
Could you make use of the updater plugin so this auto updates so dont have to check git repo :S
Originally posted by @TonyS95 in #3 (comment)
The text was updated successfully, but these errors were encountered: