Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: extend functionality of led_vmset with permanent light mode and intensity setting. #170

Closed
Scachi opened this issue Oct 27, 2018 · 6 comments
Labels

Comments

@Scachi
Copy link

Scachi commented Oct 27, 2018

As creedkiller suggested in the forum : https://www.consoletuner.com/forum/viewtopic.php?f=26&t=10479&p=73595#p73595

it would be nice to be able to use a single function for controlling the led of the T2 and controller.

At the moment we have to use led_vmset and led_set, depending on if we want blinking or permanent light. Only the later providing intensity.

Personally, I don't use intensity very often, but using a single function for blinking and permanent light might help to save some bytecode in our scripts as we don't have to use different function just for controlling the leds with some if/else statement.

I tried using a long time for the on time of the blinking, zero for off and -1 to fake permanent light but that didn't work reliable in my tests.

@J2Kbr
Copy link
Owner

J2Kbr commented Oct 30, 2018

Scachi, you should be able use led_vmset() for permanent light as you described, example:

led_vmset(LED_1, 65000, 0, -1);

Please let me know what is the issue you are having with these parameters (an example code may help). Thank you.

@Scachi
Copy link
Author

Scachi commented Oct 30, 2018

If I remember correctly it didn't kept the color active all the time, suddenly showing nothing after a while.

I'll use this code again in one of my scripts and will report back with more details when I have issues with it again.

A brightness parameter would be a great addition if this can be done via an optional parameter ;-)

@Scachi
Copy link
Author

Scachi commented Nov 2, 2018

I think I have found the issue in an old script..I was using the command in a combo without a wait(0); behind it so that was the real cause of my trouble.

I have integrated the code like you have written above in several scripts now without any trouble.

@Scachi
Copy link
Author

Scachi commented Nov 2, 2018

I close this for now and will reopen it if I have issues with it again, but I think it was all my fault

@Scachi Scachi closed this as completed Nov 2, 2018
@Scachi
Copy link
Author

Scachi commented Feb 12, 2019

Well,..problem found again..
according to the documentation this:

led_vmset(LED_1, 1000, 0, -1);

should give permanent color..
The T2 does it..but the controller led shuts off after 1 sec, it is not repeating the cycle.

led_vmset(LED_1, 65000, 0, -1);

This one only takes longer to shut off^^
It looks like it is only happen when the controller is connected via USB, via Blueooth it is working fine..tested with a ds4 v.(noidea) ..older one.

https://www.consoletuner.com/forum/viewtopic.php?f=26&t=11679&p=79759#p79757

Using latest gtuner iv and up2date firmware.

@Scachi Scachi reopened this Feb 12, 2019
@J2Kbr J2Kbr added the bug label Mar 10, 2019
@J2Kbr
Copy link
Owner

J2Kbr commented Mar 10, 2019

Cause for this behavior found and fixed on firmware 1.00RC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants