Zeroes getting returned from fetchvars

[bpbond]

Uh oh, I have a suspicion that my #496 may have broken fetchvars — although if that's the case don't know why tests didn't flag the issue! @leeyap and @BennettForville found

> library(hector)
> RCP45 <- system.file("input/hector_ssp245.ini", package = "hector")
> core45 <- newcore(RCP45)
> reference <- fetchvars(core45, NA)
> head(reference)
             scenario year variable  value    units
1 Unnamed Hector core   NA       Ca 277.15 ppmv CO2
2 Unnamed Hector core   NA     Ftot   0.00     W/m2
3 Unnamed Hector core   NA     FCO2   0.00     W/m2
4 Unnamed Hector core   NA     Tgav   0.00     degC

which doesn't look good.

[bpbond]

nm 😳

[bpbond]

Reopening. This is confusing behavior and should be fixed to warn, error, something.

[bpbond]

More fetchvars bad behavior:

> library(hector)
> hc <- newcore("./inst/input/hector_ssp245.ini")
> run(hc)
Hector core:	Unnamed Hector core
Start date:	1745
End date:	2300
Current date:	2300
Input file:	/Users/bpbond/Dropbox/Documents/Work/Code/hector/inst/input/hector_ssp245.ini
> x <- fetchvars(hc, dates = NA)
> x
             scenario year variable      value    units
1 Unnamed Hector core   NA       Ca 503.744948 ppmv CO2
2 Unnamed Hector core   NA     Ftot   3.906607     W/m2
3 Unnamed Hector core   NA     FCO2   3.363304     W/m2
4 Unnamed Hector core   NA     Tgav   2.768967     degC

(These are the 2300 values.)

This is not at all what the documentation says ("Set to NA to return data with no associated dates such as model parameters").

[bpbond]

☝️ re the zeroes, this is correct behavior. An un-run model is at 1/1/1745 (cf. #177 ) and the Ftot, FCO2, and Tgav are all zero. (And with the year fixed so it's correctly showing 1745 — see #604 — I think clear.)