Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update indicator padding calc #12

Closed
wants to merge 1 commit into from
Closed

Conversation

hysuki
Copy link

@hysuki hysuki commented Aug 2, 2020

Indicator padding issue, Indicator size gets smaller as it gets closer to the edge.

Example

indicatorStyle: IndicatorStyle(
        width: 30,
        height: 30,
        indicatorY: 0~1.0
...
indicatorY image
0 스크린샷 2020-08-02 오후 5 46 52
0.5 스크린샷 2020-08-02 오후 5 47 20
1 스크린샷 2020-08-02 오후 5 47 33

@JHBitencourt
Copy link
Owner

Thanks for the PR.
I'll give it a look soon.

@JHBitencourt JHBitencourt self-assigned this Aug 2, 2020
@JHBitencourt JHBitencourt self-requested a review August 2, 2020 21:32
@JHBitencourt
Copy link
Owner

I appreciate your PR, but I'm currently not accepting this one.

It does not address and fix all the situations when calculating the indicator padding.
In order to support horizontal timelines I refactored this calculation, as you can see here: #16

Thanks! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants