Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ktlint baseline #414

Closed
shaobin0604 opened this issue Nov 20, 2020 · 7 comments · Fixed by #475
Closed

Add support for ktlint baseline #414

shaobin0604 opened this issue Nov 20, 2020 · 7 comments · Fixed by #475
Assignees

Comments

@shaobin0604
Copy link

Ktlint https://github.com/pinterest/ktlint

to add a baseline to check against prepend following args: "--baseline=ktlint-baseline.xml"

@JLLeitschuh
Copy link
Owner

As far as I'm aware, this is not a feature we currently support yet.

@Tapchicoma please confirm?

@Tapchicoma
Copy link
Collaborator

It will be available in 0.40.0 release. Eventually this plugin will also add such support.

@Tapchicoma Tapchicoma changed the title [Question] How to add baseline to check just like ktlint does? Add support for ktlint baseline Nov 30, 2020
@s1monw1
Copy link

s1monw1 commented Feb 17, 2021

It will be available in 0.40.0 release. Eventually this plugin will also add such support.

This comment is misleading as this update already happened by now but the support for baselining isn't given yet, right? Can you give an update? Will it be included in the next update?

@Tapchicoma
Copy link
Collaborator

Adding baseline support is a separate task from updating default KtLint version to 0.40.0. I've planned to work on it for the next release as 10.0.0 already has quite a lot of changes.

@firmwaves
Copy link

is there any workaround for this in the meantime?

@firmwaves
Copy link

@Tapchicoma any updates on this? or any ways for us to help out?

@Tapchicoma
Copy link
Collaborator

I will add baseline support after #459 PR will be merged (support require some changes from KtLint 0.41.0 release).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants