Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spacing in grammar #56

Merged
merged 1 commit into from Jun 1, 2023
Merged

Fix spacing in grammar #56

merged 1 commit into from Jun 1, 2023

Conversation

digama0
Copy link
Member

@digama0 digama0 commented May 31, 2023

Adds spaces to affect the pretty printing of the aesop tactic.

@digama0 digama0 requested a review from JLimperg May 31, 2023 02:46
@@ -80,7 +80,7 @@ partial def destructProductsCore (goal : MVarId) : MetaM MVarId :=
else
return goal

elab &"aesop_destruct_products" : tactic =>
elab "aesop_destruct_products" : tactic =>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not necessary to put & in front of the initial atom in a category with leading_ident_behavior := symbol or leading_ident_behavior := both, and tactic and attr are both of that form.

@JLimperg
Copy link
Collaborator

JLimperg commented Jun 1, 2023

Thank you very much! I thought the possibility to omit & was special-cased for the tactic category, which I didn't like and therefore didn't use. But if it's (now?) tied to leading_ident_behavior, I can accept it.

@JLimperg JLimperg merged commit ca73109 into master Jun 1, 2023
1 check passed
bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Jun 2, 2023
This fixes a bunch of spacing bugs in tactics. Mathlib counterpart of:

* Lean: leanprover/lean4#2240
* Std: leanprover-community/batteries#149
* Aesop: leanprover-community/aesop#56
bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Jun 2, 2023
This fixes a bunch of spacing bugs in tactics. Mathlib counterpart of:

* Lean: leanprover/lean4#2240
* Std: leanprover-community/batteries#149
* Aesop: leanprover-community/aesop#56
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants