Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media Image Drag& Drop broken #4846

Closed
ghost opened this issue Feb 3, 2018 · 11 comments
Closed

Media Image Drag& Drop broken #4846

ghost opened this issue Feb 3, 2018 · 11 comments
Labels

Comments

@ghost
Copy link

ghost commented Feb 3, 2018

Windows 10, JMRI 4.11.2 and 4.11.3. The Roster Media image Drag & Drop feature is broke in 4.11.2 and 4.11.3. User unable to complete Drag&Drop of any media (JPG, PNG, GIF) from a folder to Roster Image frame. Greeted with a Windows red circle of denial. 4 incidents reported

@dheap dheap added the Bug label Feb 4, 2018
@KenC57
Copy link
Contributor

KenC57 commented Feb 10, 2018

Right at the start of JMRI you will see this in the log:

2018-02-10 09:09:31,704 dnd.FileDrop DEBUG - FileDrop: Drag and drop is not supported with this JVM [main]

No idea when that started or why. But it does prevent adding media to roster entries.

@KenC57
Copy link
Contributor

KenC57 commented Feb 10, 2018 via email

@ghost
Copy link
Author

ghost commented Feb 10, 2018

JVM is what in this example/case ? Is JVM = JAVA 1.8.0_161 ? then it makes no sense as JMRI 4.10 has no D&D issue under this same JVM.

@bobjacobsen
Copy link
Member

bobjacobsen commented Feb 11, 2018 via email

@ghost
Copy link
Author

ghost commented Feb 12, 2018

For what it is worth. Windows 10, 32 bit. I turned on /DEBUG and /NOISY. Do not see any message go by re " FileDrop: Drag and drop is not supported " in any log generated.

CommandLine: "C:\Program Files\JMRI\LaunchJMRI.exe" /debug /noisy apps.gui3.dp3.DecoderPro3
Default options: -J-Djogamp.gluegen.UseTempJarCache=false
AppName: DecoderPro3
Class: apps.gui3.dp3.DecoderPro3
Parameters:
Noisy: 1
Force32bit: 0
Profile:
Testing for x64...
Result: 0
JavaPath: C:\Program Files\Java\jre1.8.0_161\bin\java.exe
Create folder: C:\Users\Marc\AppData\Local\Temp\LaunchJMRI
CopyFiles: C:\Program Files\Java\jre1.8.0_161\bin\java.exe C:\Users\Marc\AppData\Local\Temp\LaunchJMRI\DecoderPro3.exe
Result: 0
JExePath: C:\Users\Marc\AppData\Local\Temp\LaunchJMRI\DecoderPro3.exe
PhysicalMemory: 2047m
Check if more than 4GB memory
Less than 4GB
Check if more than 1GB memory
More than 1GB
InitHeap: 96m
MinMemory: 192m
MaxMemory: 1023m
Checking maximum heap size...
Running x86 JVM
...finished
Checking user.home...
Reading Desktop Shell Folder registry key...
...read: C:\Users\Marc\Desktop
Checking if equal to %USERPROFILE%...
Comparing: C:\Users\Marc
to: C:\Users\Marc
user.home OK

Removed all remaining messages...

@KenC57
Copy link
Contributor

KenC57 commented Feb 12, 2018 via email

@ghost
Copy link
Author

ghost commented Feb 12, 2018

Learning.... So I changed default.lcf to request DEBUG, Al, T, R . If I did it right, I still do not see any "not supported" or anything related to " drop " message in the 862 line log. I took the CLIPBOARD and pasted it to notepad++ and searched for "DROP". No hit.


2018-02-12 17:43:05,491 util.Log4JUtil INFO - ****** JMRI log ******* [main]
2018-02-12 17:43:05,601 util.Log4JUtil INFO - This log is appended to file: C:\Users\Marc\JMRI\log\messages.log [main]
2018-02-12 17:43:05,601 util.Log4JUtil INFO - This log is stored in file: C:\Users\Marc\JMRI\log\session.log [main]
2018-02-12 17:43:05,663 apps.AppsBase INFO - DecoderPro version 4.11.3ish+jenkins+20180202T0146Z+R9762e1f starts under Java 1.8.0_161 on Windows 10 x86 v10.0 at Mon Feb 12 17:43:05 EST 2018 [main]
2018-02-12 17:43:05,695 util.FileUtilSupport DEBUG - Attempting to find resources/logo.gif in [] [main]
2018-02-12 17:43:11,288 apps.AppsBase DEBUG - Config file set to: DecoderProConfig3.xml [main]
2018-02-12 17:43:11,288 util.Log4JUtil DEBUG - initLog4J already initialized! [main]
2018-02-12 17:43:11,882 util.FileUtilSupport DEBUG - Using C:\Users\Marc\JMRI\Digitrax_Loconet_Simulator/ [main]
2018-02-12 17:43:11,913 util.FileUtilSupport DEBUG - Using C:\Users\Marc\JMRI\Digitrax_PR3_DCS100/ [main]
2018-02-12 17:43:11,913 util.FileUtilSupport DEBUG - Using C:\Users\Marc\JMRI\Digitrax_PR3_Programmer/ [main]
2018-02-12 17:43:11,929 util.FileUtilSupport DEBUG - Using C:\Users\Marc\JMRI\Digitrax_LBSerial_DCS100/ [main]
2018-02-12 17:43:11,929 util.FileUtilSupport DEBUG - Using C:\Users\Marc\JMRI\ [main]
2018-02-12 17:43:11,960 profile.ProfileManager DEBUG - Using config file C:\Users\Marc\JMRI\DecoderProConfig3.properties [main]
2018-02-12 17:43:12,195 profile.ProfileManager DEBUG - Looking for profile Digitrax_Loconet_Simulator.3ee94b4e, found Digitrax_Loconet_Simulator.3ee94b4e [main]

@silverailscolo
Copy link
Contributor

On macOS 10.13.3 High Sierra with Java 8 Update 161 I see the same behavior when trying in vain to drag a PNG or JPEG image to the Roster Media rects (DEBUG on for path jmri.jmrit.roster):

2018-02-13 00:18:39,225 swing.ResizableImagePanel             DEBUG - Image path is now : null [AWT-EventQueue-0]
2018-02-13 00:18:39,228 dnd.FileDrop                          DEBUG - FileDrop: Drag and drop is not supported with this JVM [AWT-EventQueue-0]

@KenC57
Copy link
Contributor

KenC57 commented Feb 12, 2018 via email

@ghost
Copy link
Author

ghost commented Feb 13, 2018

I also have a second system and it is also running Windows 10 Home N 1709 and JAVA 1.8.0_161. It is running JMRI 4.10 at the present time. The drag and drop works perfectly. So I submit the issue is not from JAVA 1.8.0_161. And Ken. I am running a 32 bit OS here if it matters any.

@ghost
Copy link
Author

ghost commented Feb 13, 2018

I now see a tentative fix in 4.11.3 was done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants