New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConcurrentModificationException #70

Closed

maxencehenneron opened this issue Jan 6, 2018 · 3 comments

Labels

Bug v2.0

maxencehenneron commented Jan 6, 2018

The recoveryQueue in RakNetSession.java isn't synchronized, causing such exceptions:

java.util.ConcurrentModificationException
at java.util.HashMap$HashIterator.nextNode(HashMap.java:1437)
at java.util.HashMap$ValueIterator.next(HashMap.java:1466)
at net.marfgamer.jraknet.session.RakNetSession.update(RakNetSession.java:837)
at net.marfgamer.jraknet.server.RakNetServer.start(RakNetServer.java:803)
at net.marfgamer.jraknet.server.RakNetServer$1.run(RakNetServer.java:837)

Owner

whirvis commented Jan 11, 2018

Thanks for reporting this, I'll get onto fixing it right away!

Owner

whirvis commented Jan 11, 2018 •

edited

I have created concurrent types for ByteMap, ShortMap, IntMap, and LongMap with their respective names but with Concurrent prefixed behind them. They function the exact the same with their code completely unchanged except for the fact that they extend ConcurrentHashMap rather than just HashMap :) This issue should no longer happen. Sorry for taking so long to respond, I was gone from GitHub for much longer than I normally am so I did not see this until I finally logged back in.

whirvis added a commit that referenced this issue


          Fixed #69 and #70

b49c22b

I decided to revert to #69 based on @johnnywoof's request and fixed another ConcurrentModificationException (sneaky little bastards) discovered by @dernise.

whirvis closed this as completed

HoverEpic commented Jan 11, 2018

Thanks a lot.

The Dragonet team.

whirvis added Bug Known Fix labels

whirvis added a commit that referenced this issue


          Fixed #69 and #70

0eb4674

I decided to revert to #69 based on @johnnywoof's request and fixed another ConcurrentModificationException (sneaky little bastards) discovered by @dernise.

whirvis added a commit that referenced this issue


          Fixed #69 and #70

72b64ed

I decided to revert to #69 based on @johnnywoof's request and fixed another ConcurrentModificationException (sneaky little bastards) discovered by @dernise.

whirvis added a commit that referenced this issue


          Fixed #69 and #70

92adc1a

I decided to revert to #69 based on @johnnywoof's request and fixed another ConcurrentModificationException (sneaky little bastards) discovered by @dernise.

whirvis added a commit that referenced this issue


          Fixed #69 and #70

b4c6903

I decided to revert to #69 based on @johnnywoof's request and fixed another ConcurrentModificationException (sneaky little bastards) discovered by @dernise.

whirvis added a commit that referenced this issue


          Fixed #69 and #70

dd76efe

I decided to revert to #69 based on @johnnywoof's request and fixed another ConcurrentModificationException (sneaky little bastards) discovered by @dernise.

whirvis added a commit that referenced this issue


          Fixed #69 and #70

7b37f1c

I decided to revert to #69 based on @johnnywoof's request and fixed another ConcurrentModificationException (sneaky little bastards) discovered by @dernise.

whirvis added a commit that referenced this issue


          Fixed #69 and #70

238b0c5

I decided to revert to #69 based on @johnnywoof's request and fixed another ConcurrentModificationException (sneaky little bastards) discovered by @dernise.

whirvis added a commit that referenced this issue


          Fixed #69 and #70

39b833b

I decided to revert to #69 based on @johnnywoof's request and fixed another ConcurrentModificationException (sneaky little bastards) discovered by @dernise.

whirvis added the v2.0 label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment