Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Non-existent CommonJS backward compatibility #1016

Closed
filiphsps opened this issue Aug 27, 2023 · 1 comment
Closed

Bug: Non-existent CommonJS backward compatibility #1016

filiphsps opened this issue Aug 27, 2023 · 1 comment
Assignees
@filiphsps
Labels
Bug Something not working as it should or even going terribly wrong Dependants Issues and bugs for people leveraging us as dependency Enhancement New feature or request that aren’t blocking and would just be “nice to have”

Comments

@filiphsps
Copy link
Member

Would be nice to get it working for the downstream package even if we’re not really targeting commonjs. I’ll take ownership of this and see what can be done!

src/sleepingBedrock.ts:20:20 - error TS1479: The current file is a CommonJS module whose imports will produce 'require' calls; however, the referenced file is an ECMAScript module and cannot be imported with 'require'. Consider
writing a dynamic 'import("@jsprismarine/prismarine/dist/config/Config")' call instead.

cc @vincss
@filiphsps filiphsps added Enhancement New feature or request that aren’t blocking and would just be “nice to have” Dependants Issues and bugs for people leveraging us as dependency labels Aug 27, 2023
@filiphsps filiphsps self-assigned this Aug 27, 2023
@filiphsps filiphsps added the Bug Something not working as it should or even going terribly wrong label Aug 27, 2023
@filiphsps filiphsps changed the title (barebones) CommonJS backward compatibility Bug: Non-existent CommonJS backward compatibility Aug 27, 2023
This was referenced Sep 5, 2023
Closed
Open
@filiphsps
Copy link
Member Author

This has finally been completed. @vincss :^)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@filiphsps filiphsps

Labels
Bug Something not working as it should or even going terribly wrong Dependants Issues and bugs for people leveraging us as dependency Enhancement New feature or request that aren’t blocking and would just be “nice to have”
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@filiphsps