Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependencies issues by releasing a new patch version #701

Closed
vincss opened this issue Mar 14, 2022 · 3 comments
Closed

Fix dependencies issues by releasing a new patch version #701

vincss opened this issue Mar 14, 2022 · 3 comments
Labels
Security Security or privacy issue

Comments

@vincss
Copy link

vincss commented Mar 14, 2022

Hi !
First, thanks for the good work on this project !

I've got a small project that uses this one but only respond on client connections :
https://github.com/vincss/mcsleepingserverstarter

I'm facing a small issue which is that the dependabot of github is creating security issue for this dependence.
Would it be possible to create a maintenance version with those dependencies updated ?
image
image
image

Thanks !

@enricoangelon enricoangelon self-assigned this May 2, 2022
@enricoangelon enricoangelon added the Work In Progress Somebody has taken ownership of this issue and is currently working on it label Dec 31, 2022
@filiphsps
Copy link
Member

Sorry for the extremely late response. Just bumped the package to 0.1.0-rc.50. Not sure if everything still works though (I mean there’s like 700 commits between releases and neither of us have really had time to maintain this). Let us know how it goes! 🤠

@filiphsps filiphsps added Security Security or privacy issue and removed Work In Progress Somebody has taken ownership of this issue and is currently working on it labels Aug 17, 2023
@vincss
Copy link
Author

vincss commented Aug 18, 2023

Hi,
Thanks for the release.

When I try to update the package, I cannot build it :
src/sleepingBedrock.ts:20:20 - error TS1479: The current file is a CommonJS module whose imports will produce 'require' calls; however, the referenced file is an ECMAScript module and cannot be imported with 'require'. Consider
writing a dynamic 'import("@jsprismarine/prismarine/dist/config/Config")' call instead.

I tried to update my project to esm, but there is so many issues when doing it.

@filiphsps
Copy link
Member

Hi, Thanks for the release.

When I try to update the package, I cannot build it : src/sleepingBedrock.ts:20:20 - error TS1479: The current file is a CommonJS module whose imports will produce 'require' calls; however, the referenced file is an ECMAScript module and cannot be imported with 'require'. Consider writing a dynamic 'import("@jsprismarine/prismarine/dist/config/Config")' call instead.

I tried to update my project to esm, but there is so many issues when doing it.

Hi, thanks for letting me know! I’ll take a look as soon as I have a little free time. Missed this message so feel free to reach out on Discord or Twitter next time for a little more swift response :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Security Security or privacy issue
Projects
None yet
Development

No branches or pull requests

3 participants