Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lodash dependency #1

Open
scott-w opened this issue Jun 3, 2017 · 5 comments
Open

lodash dependency #1

scott-w opened this issue Jun 3, 2017 · 5 comments

Comments

@scott-w
Copy link
Contributor

scott-w commented Jun 3, 2017

Was just running through the source and saw a dependency on lodash in the package.json. Is this a hard dependency for this to work or would underscore work just as well?
@JSteunou
Copy link
Owner

JSteunou commented Jun 3, 2017

Hard dependency. I am using lodash throttle. some and isNumber are underscore compatible.
Maybe I should emded those fonctions ? What do you think ?

@scott-w
Copy link
Contributor Author

scott-w commented Jun 4, 2017

Underscore has throttle too (http://underscorejs.org/#throttle) - is there a difference in their API?

In terms of embedding, I'm assuming most users would have lodash or underscore installed already?

@JSteunou
Copy link
Owner

JSteunou commented Jun 4, 2017

Lodash throttle can be canceled

@scott-w
Copy link
Contributor Author

scott-w commented Jun 5, 2017

Fair enough, that makes sense. I can update the README with a note on that if you like?

@JSteunou
Copy link
Owner

JSteunou commented Jun 5, 2017

Sure, could be useful !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scott-w @JSteunou