Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Negative boosts are not supported in ES 7 #73

Open
michelole opened this issue Jul 30, 2019 · 4 comments
Open

Negative boosts are not supported in ES 7 #73

michelole opened this issue Jul 30, 2019 · 4 comments
Assignees
@michelole @khituras
Labels
P0 Highest priority issues, a MUST

Comments

@michelole
Copy link
Collaborator

michelole commented Jul 30, 2019 •
edited

Used for negative_boosters.json, match_all.json, and other.json.

  • negative_boosters.json and other.json should be migrated to query boosting. Caveat: static boosting might lead to different results (better? worse? same?)
  • match_all.json: boost = 0
  • other.json could also be migrated to a should_not query.

Test with 2017 and 2018 data. Validate on internal 2019 GS.
@michelole michelole added the P0 Highest priority issues, a MUST label Jul 30, 2019
@michelole michelole mentioned this issue Jul 30, 2019
Closed
@michelole
Copy link
Collaborator Author

@khituras other.json (used to downrank matches on comorbidities in CT exclusion criteria) also has a negative boost. However, it doesn't happen together with negative_boosters.json (used only for BA).

@michelole
Copy link
Collaborator Author

michelole commented Jul 31, 2019 •
edited

Worst case scenario we could try a must_not clause. Update: they don't seem to improve results either.

@michelole
Copy link
Collaborator Author

match_all could be switched to a match on any "cancer" or "gene"/"mutation".

@michelole
Copy link
Collaborator Author

This is being solved by reverting back to an ES 5.4 index (see also #84).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michelole michelole

@khituras khituras

Labels
P0 Highest priority issues, a MUST
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michelole @khituras