Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix url & request param normalization #85

Merged
merged 2 commits into from Aug 28, 2021
Merged

Conversation

JWCook
Copy link
Member

@JWCook JWCook commented Aug 28, 2021

Fixes #84

This fix ensures that any equivalent variations on a URL and request parameters result in the same cache key.

@JWCook JWCook added the bug Something isn't working label Aug 28, 2021
@JWCook JWCook added this to the v0.5 milestone Aug 28, 2021
@JWCook JWCook force-pushed the fix-url-param-normalization branch 2 times, most recently from 1e72f45 to bba3150 Compare August 28, 2021 03:28
@JWCook JWCook force-pushed the fix-url-param-normalization branch from bba3150 to a8b7501 Compare August 28, 2021 03:33
@JWCook JWCook merged commit 63e63f9 into main Aug 28, 2021
@JWCook JWCook deleted the fix-url-param-normalization branch August 28, 2021 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CacheBackend.has_url and delete_url do not work if the params argument is used to make the request
1 participant