Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack v4 Support #137

Closed
teod opened this issue Feb 26, 2018 · 17 comments
Closed

Webpack v4 Support #137

teod opened this issue Feb 26, 2018 · 17 comments

Comments

@teod
Copy link

teod commented Feb 26, 2018

TypeError: Cannot read property 'plugin' of undefined at stylelintWebpackPlugin.runCompilation (node_modules/stylelint-webpack-plugin/lib/run-compilation.js:38:12)

@wellyshen
Copy link

I have the same issue.

@DotCoyote
Copy link

I get this only in Dev-Mode. Production Build runs just fine.
Maybe it's related to some Middleware/HMR?

@andreyvolokitin
Copy link

@CinKon the error stack mentions a lot of webpack-dev-server...

@lerit
Copy link

lerit commented Mar 23, 2018

same issue,

@shellscape
Copy link
Contributor

@andreyvolokitin @lerit @teod @wellyshen @CinKon you might consider trying webpack-serve, as it's a little less brittle than webpack-dev-server, but this one looks like an issue in the stylelint plugin itself.

@ifier
Copy link

ifier commented Mar 28, 2018

The same. I'm using:
webpack-dev-middleware
webpack-hot-middleware
express

/Users/denys/Development/cmwa-mobile/node_modules/stylelint-webpack-plugin/lib/run-compilation.js:38
  compiler.plugin(compilerMethod, function (compilation, next) {
          ^

TypeError: Cannot read property 'plugin' of undefined
    at stylelintWebpackPlugin.runCompilation (/Users/denys/Development/cmwa-mobile/node_modules/stylelint-webpack-plugin/lib/run-compilation.js:38:11)

When building an app - npm run dev || npm run build, everything is fine.

@bymathias
Copy link

same issue

@shellscape
Copy link
Contributor

@bymathias please don't post "me too" or "same issue" replies. Instead, use the reaction buttons on the original post.

@wellyshen
Copy link

any update for this issue?

@shellscape
Copy link
Contributor

@wellyshen when there are updates Github will display them in the issue or any linked/referenced Pull Requests. Until then, please be patient while the maintainers work around their schedule to get this update in.

@pattiereaves
Copy link

FYI, using webpack-serve I got the same issue.

@shellscape
Copy link
Contributor

Just wanted to drop a small comment, not really an update, but to let everyone know that we're not hiding from this one:

The developer who has the active PR (#140) to resolve this has vanished and we're doing our due diligence to get ahold of them so we can proceed with their PR. It's unfortunately blocking a fix at this very moment, but we've got to give them the chance to pop back up and respond. We all know how important getting this fixed is and that it's holding up a ton of users, and we're on top of it.

@shellscape
Copy link
Contributor

#144 is ready and awaiting review and merge. Once that happens, we'll publish a patch release for Webpack v4. Should be within the next day or so.

@shellscape
Copy link
Contributor

Closed in #144. Will be publishing a patch release shortly.

Please note that the next release of this plugin will likely be a major version that will put the plugin requirement in line with the rest of the webpack ecosystem standard. That means minimum requirements will be Node v6+ and Webpack v4+.

@mttmccb
Copy link

mttmccb commented May 1, 2018

Where can I track when the 0.10.4 is released on NPM? Presumably it's not because of breaking changes?

@shellscape
Copy link
Contributor

@mttmccb apologies, but I can't understand what you're trying to ask?

@mttmccb
Copy link

mttmccb commented May 1, 2018

Sorry ignore me, last time I checked it was only installing 0.10.3 so I though it hadn't been released yet, it's fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants