Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lintDirtyModulesOnly when matching path on Windows #124

Merged
merged 3 commits into from Jan 14, 2018
Merged

Fix lintDirtyModulesOnly when matching path on Windows #124

merged 3 commits into from Jan 14, 2018

Conversation

MQuy
Copy link
Contributor

@MQuy MQuy commented Dec 20, 2017 •
edited

I run with lintDirtyModulesOnly option on Window, it doesn't work due to minimatch's problem on Window. After changing minimatch into micromatch it works fine in my case, and performance is a bit better.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.718% when pulling 58d57c2 on MQuy:master into 16c3d41 on JaKXz:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.718% when pulling 58d57c2 on MQuy:master into 16c3d41 on JaKXz:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.718% when pulling 58d57c2 on MQuy:master into 16c3d41 on JaKXz:master.

JaKXz
JaKXz approved these changes Dec 22, 2017
View reviewed changes
Copy link
Contributor

@JaKXz JaKXz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MQuy thank you for your contribution! This looks like a great change. Ignore the bitHound failures, I was just trying out that service, I will remove it from the CI checks.

Unfortunately I'm not sure why node v9 is failing, I'll try to investigate.

@MQuy
Copy link
Contributor Author

MQuy commented Dec 22, 2017

@JaKXz, it is quite strange that it causes an error. The only major change is related to micromatch, but this library is used by stylelint ..., it shouldn't be a problem 🤔

@JaKXz JaKXz changed the title Fix lintDirtyModulesOnly when matching path on Window Fix lintDirtyModulesOnly when matching path on Windows Dec 22, 2017
@JaKXz
Copy link
Contributor

JaKXz commented Dec 22, 2017

The issue is with npm-install-version which we use to install different versions of webpack in tests.

I don't have the cycles atm to look into that package, but please feel free to do the deep dive :)

@JaKXz JaKXz merged commit 3688d08 into webpack-contrib:master Jan 14, 2018
@JaKXz
Copy link
Contributor

JaKXz commented Jan 14, 2018

+ stylelint-webpack-plugin@0.10.1 has been published. Thanks for your contribution, @MQuy :)

joshwiens pushed a commit that referenced this pull request Mar 31, 2018
@MQuy @joshwiens
fix: lintDirtyModulesOnly matching path on Windows (#124)
f7eaae2 
* Add micromatch

* Use micromatch to check changes

* Remove matchbase in micromatch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaKXz JaKXz JaKXz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MQuy @coveralls @JaKXz