Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue with webpack 4 #139

Closed
wants to merge 1 commit into from

Conversation

waterfoul
Copy link

Fixes the issue in #137. Note: I did not fully test everything with webpack 4 so I would not say it's "supported" but with this patch it will work

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.5%) to 96.25% when pulling 0f558d3 on waterfoul:master into 04e0f69 on JaKXz:master.

@coveralls
Copy link

coveralls commented Feb 27, 2018

Coverage Status

Coverage decreased (-2.5%) to 96.25% when pulling 0f46e8f on waterfoul:master into 04e0f69 on JaKXz:master.

@waterfoul
Copy link
Author

CI failed due to webpack 4 dropping support for node 4 (which is EOL in 2 months). Does this project still need to support node 4?

@teod
Copy link

teod commented Feb 28, 2018

this doesn't use the new webpack tappable api, but I suggest to still merge it so we can unblock webpack v4 update.

Copy link
Contributor

@JaKXz JaKXz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution, but I think I'm going to favour #140 over this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants