Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added lang support for go, js, and cs #1

Merged

Conversation

YasserDbeis
Copy link
Contributor

Went ahead an implemented the lang support for go, cs, and javascript.

One thing I believe we need to come to consensus of is the version of each compiler/interpreter that should be downloaded. As it stands, the most recent version is downladed through 'sudo apt-get install [compiler/interpreter]'. But this may not match up with the language versions hardcoded in the program/may break the endpoints with future updates. Thus, as aforementioned, I propose we standardize the version downloaded in the apt-get install command to avoid such inconsistencies. Wanted to run it by you first though Jaagrav.

Thanks for the great api. Cheers!

@Jaagrav Jaagrav changed the base branch from master to add-cs-go-js-support June 8, 2022 11:44
@Jaagrav
Copy link
Owner

Jaagrav commented Jun 8, 2022

Thanks for the PR, will do some checks before I deploy this.

I agree with what you say, in fact I was planning on making that hard coded version part dynamic, i.e. use spawn in order to get the version and return the compiler version instead how it is currently. I got a bit lazy there but yes thanks for bringing light to this, will fix it soon. Standardizing the version might not be the right way to do this, instead keeping it latest and returning the right version would probably be better, what do you think?

@Jaagrav Jaagrav merged commit 4a1899f into Jaagrav:add-cs-go-js-support Jun 8, 2022
@Jaagrav Jaagrav mentioned this pull request Jun 9, 2022
@YasserDbeis
Copy link
Contributor Author

Thanks for the PR, will do some checks before I deploy this.

I agree with what you say, in fact I was planning on making that hard coded version part dynamic, i.e. use spawn in order to get the version and return the compiler version instead how it is currently. I got a bit lazy there but yes thanks for bringing light to this, will fix it soon. Standardizing the version might not be the right way to do this, instead keeping it latest and returning the right version would probably be better, what do you think?

Yeah, I think the dynamic approach/using the latest version is also ideal!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants