Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinte scroll for all comments #14

Open
1 of 2 tasks
miwurster opened this issue Dec 30, 2017 · 2 comments
Open
1 of 2 tasks

Infinte scroll for all comments #14

miwurster opened this issue Dec 30, 2017 · 2 comments

Comments

@miwurster
Copy link

miwurster commented Dec 30, 2017

Currently, the comment on a page is only shown if one is on the current page.

image

Solutions:

  • Toggle button to show all or only on the current page
  • Infinite scroll where the comments on the current page are shown. See how Acrobat Reader solves that issue when infinite scroll is enabled @koppor

Search for empty string should display all entries dependent on "show all" toggle button: If "all": show all, if "current page": show all entries of current page.

@koppor koppor changed the title Toggle button for all comments Infinte scroll for all comments Jan 9, 2018
@koppor
Copy link
Member

koppor commented Jan 9, 2018

Infinite scroll:

Like word

grafik

Acrobat can't do it:

grafik

@koppor
Copy link
Member

koppor commented Jan 9, 2018

  • if show all: First comment should be the first comment on the current page. Meaning: display comments n to m, where n is the current page and m is the last page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants