Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "reset to default" button for "Cite command" #10569

Closed
koppor opened this issue Oct 24, 2023 · 7 comments · Fixed by #10580
Closed

Add "reset to default" button for "Cite command" #10569

koppor opened this issue Oct 24, 2023 · 7 comments · Fixed by #10580
Assignees
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty.

Comments

@koppor
Copy link
Member

koppor commented Oct 24, 2023

We need a button "Reset to default" for the "Cite command". A user might put arbitrary strings there - and we need to support them to go back to the default easily. The default is \cite{key1,key2}.

image

The icon and the label text can be found in "Citation key patterns":

a

Refs #10568

@koppor koppor added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Oct 24, 2023
@JonathanRech
Copy link
Contributor

Hello @koppor , I would like to try work on this issue.

For clarification: I should add a Button to "Cite Command" that uses the icon and labeltext like in "Citation key patterns"

@SUPWEZZ
Copy link

SUPWEZZ commented Oct 24, 2023

Hi @koppor, since the previous two issues were unassigned, may I do this new issue?

@Siedlerchr
Copy link
Member

@JonathanRech was first

For clarification: I should add a Button to "Cite Command" that uses the icon and labeltext like in "Citation key patterns"

Not only the button but also the functionality needs to be implemented. The value of the pattern should be reset to the default value.

@calixtus
Copy link
Member

Why an extra button to reset this? Maybe a tooltip or an example string on the right is better.
The reset functionality is provided by the preferences dialog itsellf and the current implementation with the defaults map is soon to be replaced anyways.

@Siedlerchr
Copy link
Member

@calixtus You can reset the entry preview as well. Same for custom entry types. So this is totally fine. And button we mean a simple icon.

@koppor
Copy link
Member Author

koppor commented Oct 25, 2023

Why an extra button to reset this? Maybe a tooltip or an example string on the right is better.

@calixtus Because we like fine-grained reset-to-defaults 😅. Moreover, this is a highly-needed work-around for #10568. -- https://github.com/JabRef/jabref-issue-melting-pot/issues/323 is the longer solution, but we need an internal agreement to make that issue public.

@calixtus
Copy link
Member

We had quick discussion about it. I'm fine with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants