Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of indexed files grows after reindexing action #11378

Open
2 tasks done
InAnYan opened this issue Jun 17, 2024 · 1 comment
Open
2 tasks done

Number of indexed files grows after reindexing action #11378

InAnYan opened this issue Jun 17, 2024 · 1 comment
Assignees

Comments

@InAnYan
Copy link
Collaborator

InAnYan commented Jun 17, 2024

JabRef version

5.13 (latest release)

Operating system

Windows

Details on version and operating system

No response

Checked with the latest development build (copy version output from About dialog)

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

  1. Look at the background tasks. There will be status of full-text indexing. In this status you will see "N of M files were added to the index".
  2. Perform "Rebuild full-text search indexing" action (through main menu -> Tools -> "Rebuild full-text search indexing")
  3. Now, the N number will be zeroed, but M will be greater than it was.

As I understand, M should stay either constant or get bigger or smaller if the user added or removed entry from library.

Appendix

I don't have a big library with linked files to test it thoroughly.

But I found this bug, when I was implementing my own "linked file processing" logic. I was copy-pasting (not exactly true) from PdfIndexer code (and other classes), and I have found that the variable numOfIndexedFiles in IndexingTaskManager class was never decremented or unchanged when calling the rebuildIndex method.

@InAnYan InAnYan changed the title Number of indexed files increments after reindexing action Number of indexed files grows after reindexing action Jun 17, 2024
@koppor
Copy link
Member

koppor commented Jun 17, 2024

Will be fixed in #11326

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants