Source tab doi #3104
Merged
Source tab doi #3104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The panel is now updated correctly, however, upon hitting "replace entry" after fetching the BibTeX data there are still some exceptions: Log File |
|
Indeed, thanks for pointing out! Should be fixed now. It seems that we (I) need be more careful when updating FX components based on model events. |
Siedlerchr
reviewed
Aug 14, 2017
| @@ -219,7 +219,9 @@ public void keyPressed(java.awt.event.KeyEvent e) { | |||
| public synchronized void listen(FieldAddedOrRemovedEvent event) { | |||
| // other field deleted -> update other fields tab | |||
| if (OtherFieldsTab.isOtherField(entryType, event.getFieldName())) { | |||
| rebuildOtherFieldsTab(); | |||
| DefaultTaskExecutor.runInJavaFXThread(() -> { | |||
There was a problem hiding this comment.
You can actually omit the curly braces and write it as one liner:
DefaultTaskExecutor.runInJavaFXThread(() -> rebuildOtherFieldsTab());
Siedlerchr
approved these changes
Aug 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3103 by making sure that updates to the source tab are always performed on the FXApplication Thread.
gradle localizationUpdate?