Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added file link has absolute instead of relative path #4241

Closed
1 task done
lisifdeoral opened this issue Jul 29, 2018 · 6 comments
Closed
1 task done

added file link has absolute instead of relative path #4241

lisifdeoral opened this issue Jul 29, 2018 · 6 comments
Assignees
Projects

Comments

@lisifdeoral
Copy link

lisifdeoral commented Jul 29, 2018

JabRef version 4.3.1 on Windows 10

Jabref generates an absolute path to file if the relative path would "climb" the directory tree

Steps to reproduce:
0. assume you have a file "C:\foo\file.pdf"

  1. set file directory (whether main, general, or user-specific) to "C:\bar"
  2. right click on any JabRef entry -> select "Attach file"
  3. navigate to and select "C:\foo\file.pdf"
  4. The path to file will be stored in absolute format "C:\foo\file.pdf" instead of relative "..\foo\file"

Note that JabRef (at least on Windows) still handles correctly relative paths which include ".." (or start with "\") as long as you type them yourselves.

@Siedlerchr
Copy link
Member

Duplicate of #4201

Thank you for reporting this issue. We think, that is already fixed in our development version and consequently the change will be included in the next release.

We would like to ask you to use a development build from https://builds.jabref.org/master and report back if it works for you. Please remember to make a backup of your library before trying-out this version.

@lisifdeoral
Copy link
Author

Thanks for the very quick response!

I tested the latest master and the issue does not seem to be solved.
(I apologise for not having tested the master before posting!)

Version:
JabRef 5.0-dev--snapshot--2018-07-25--master--077fdacc2
Windows 10 10.0 x86
Java 1.8.0_171

I can provide further info if needed.

@Siedlerchr Siedlerchr reopened this Jul 30, 2018
@tobiasdiez tobiasdiez added this to Needs triage in Bugs via automation Jul 30, 2018
@Siedlerchr
Copy link
Member

I found the issue. The file only gets relativized if you hit the browse button.
Already an idea how to fix this, but I am off until sunday.

@Siedlerchr Siedlerchr self-assigned this Jul 30, 2018
Bugs automation moved this from Needs triage to Closed Aug 10, 2018
@Siedlerchr
Copy link
Member

Thank you for reporting this issue. We think, that is already fixed in our development version and consequently the change will be included in the next release.

We would like to ask you to use a development build from https://builds.jabref.org/master and report back if it works for you. Please remember to make a backup of your library before trying-out this version.

@dropbearII
Copy link

I just tested the latest master and development snapshop. The file attachment is still not working. I've tried adding via General -> "+" and via right clicking on the enry.

Win 7, 64bit
https://builds.jabref.org/master/JabRef-5.0-dev--snapshot--2018-11-21--master--c19f3a46a.jar
Java version 8.0.1910.12

@tobiasdiez
Copy link
Member

@dropbearII what exactly is not working for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Bugs
  
Done
Development

No branches or pull requests

4 participants